Sign upLogin

archivesspace/archivesspace

View on GitHub
Star
frontend/app/assets/javascripts/space_calculator.js

Summary

Maintainability
D
2 days
Test Coverage

File space_calculator.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//= require linker
//= require tablesorter/jquery.tablesorter.min

function SpaceCalculatorForContainerLocation($container) {
  this.$btn = $container.find('.show-space-calculator-btn');
Severity: Minor
Found in frontend/app/assets/javascripts/space_calculator.js - About 2 hrs to fix

    Function setupByBuildingSearch has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    SpaceCalculatorModal.prototype.setupByBuildingSearch = function () {
  var self = this;

  var $building = self.$modal.find('#building');
  var $floor = self.$modal.find('#floor');
    Severity: Minor
    Found in frontend/app/assets/javascripts/space_calculator.js - About 2 hrs to fix

      Function setupResults has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      SpaceCalculatorModal.prototype.setupResults = function () {
  var self = this;

  $(':input[name=linker-item]', self.$results).each(function () {
    var $input = $(this);
      Severity: Minor
      Found in frontend/app/assets/javascripts/space_calculator.js - About 1 hr to fix

        Function SpaceCalculatorModal has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function SpaceCalculatorModal(options) {
  var self = this;

  self.options = options;
        Severity: Minor
        Found in frontend/app/assets/javascripts/space_calculator.js - About 1 hr to fix

          Function setupForm has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          SpaceCalculatorModal.prototype.setupForm = function ($form) {
  var self = this;

  self.$results = self.$modal.find('#spaceCalculatorResults');
          Severity: Minor
          Found in frontend/app/assets/javascripts/space_calculator.js - About 1 hr to fix

            Function setupResultsFilter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            SpaceCalculatorModal.prototype.setupResultsFilter = function () {
  var self = this;
  var $input = self.$results.find('#searchResultsFilter');
  var searchTimeout;
            Severity: Minor
            Found in frontend/app/assets/javascripts/space_calculator.js - About 1 hr to fix

              Function setupResults has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              SpaceCalculatorModal.prototype.setupResults = function () {
  var self = this;

  $(':input[name=linker-item]', self.$results).each(function () {
    var $input = $(this);
              Severity: Minor
              Found in frontend/app/assets/javascripts/space_calculator.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (!$.isEmptyObject(rooms)) {
        $room.empty();
        $room.append($('<option>'));
        for (var room in rooms) {
          $room.append($('<option>').html(room));
              Severity: Major
              Found in frontend/app/assets/javascripts/space_calculator.js and 1 other location - About 3 hrs to fix
              frontend/app/assets/javascripts/space_calculator.js on lines 159..166

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (!$.isEmptyObject(floors)) {
        $floor.empty();
        $floor.append($('<option>'));
        for (var floor in floors) {
          $floor.append($('<option>').html(floor));
              Severity: Major
              Found in frontend/app/assets/javascripts/space_calculator.js and 1 other location - About 3 hrs to fix
              frontend/app/assets/javascripts/space_calculator.js on lines 175..182

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                self.$modal
    .find('#byBuilding')
    .on('hide.bs.collapse', function () {
      self.$modal.find('#byBuilding :input').prop('disabled', true);
    })
              Severity: Major
              Found in frontend/app/assets/javascripts/space_calculator.js and 1 other location - About 2 hrs to fix
              frontend/app/assets/javascripts/space_calculator.js on lines 135..142

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                self.$modal
    .find('#byLocation')
    .on('hide.bs.collapse', function () {
      self.$modal.find('#byLocation :input').prop('disabled', true);
    })
              Severity: Major
              Found in frontend/app/assets/javascripts/space_calculator.js and 1 other location - About 2 hrs to fix
              frontend/app/assets/javascripts/space_calculator.js on lines 126..133

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  $('td', $input.closest('tr')).click(function (event) {
      event.preventDefault();

      $input.trigger('click');
    });
              Severity: Minor
              Found in frontend/app/assets/javascripts/space_calculator.js and 1 other location - About 50 mins to fix
              frontend/app/assets/javascripts/linker.js on lines 185..189

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status