Sign upLogin

archivesspace/archivesspace

View on GitHub
Star
frontend/app/assets/javascripts/subrecord_merge.crud.js

Summary

Maintainability
D
1 day
Test Coverage

Function init_subrecord_form has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  $.fn.init_subrecord_form = function () {
    $(this).each(function () {
      var $this = $(this);

      if (
Severity: Major
Found in frontend/app/assets/javascripts/subrecord_merge.crud.js - About 5 hrs to fix

    Function init has 111 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          var init = function (callback) {
        // Proxy the event onto the subrecord's form
        // This is used by utils.js to initialise the asYouGo
        // behaviour (quick addition of subrecords)
        $(document).on(
    Severity: Major
    Found in frontend/app/assets/javascripts/subrecord_merge.crud.js - About 4 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    var index_data = {
                path: AS.quickTemplate(
                  $target_subrecord_list.data('name-path'),
                  { index: $this.data('form_index') }
                ),
      Severity: Major
      Found in frontend/app/assets/javascripts/subrecord_merge.crud.js and 1 other location - About 2 hrs to fix
      frontend/app/assets/javascripts/subrecord_merge.crud.js on lines 137..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    var index_data = {
                path: AS.quickTemplate(
                  $target_subrecord_list.data('name-path'),
                  { index: $this.data('form_index') }
                ),
      Severity: Major
      Found in frontend/app/assets/javascripts/subrecord_merge.crud.js and 1 other location - About 2 hrs to fix
      frontend/app/assets/javascripts/subrecord_merge.crud.js on lines 103..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status