arey/angular-musicbrainz

View on GitHub
app/lib/angular-sanitize/angular-sanitize.js

Summary

Maintainability
C
1 day
Test Coverage

Function htmlParser has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function htmlParser( html, handler ) {
  var index, chars, match, stack = [], last = html;
  stack.last = function() { return stack[ stack.length - 1 ]; };

  while ( html ) {
Severity: Major
Found in app/lib/angular-sanitize/angular-sanitize.js - About 3 hrs to fix

    File angular-sanitize.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * @license AngularJS v1.2.13
     * (c) 2010-2014 Google, Inc. http://angularjs.org
     * License: MIT
     */
    Severity: Minor
    Found in app/lib/angular-sanitize/angular-sanitize.js - About 2 hrs to fix

      Function htmlSanitizeWriter has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function htmlSanitizeWriter(buf, uriValidator){
        var ignore = false;
        var out = angular.bind(buf, buf.push);
        return {
          start: function(tag, attrs, unary){
      Severity: Minor
      Found in app/lib/angular-sanitize/angular-sanitize.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                  if (handler.comment) handler.comment( html.substring( 4, index ) );
        Severity: Major
        Found in app/lib/angular-sanitize/angular-sanitize.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                } else if ( BEGING_END_TAGE_REGEXP.test(html) ) {
                  match = html.match( END_TAG_REGEXP );
          
                  if ( match ) {
                    html = html.substring( match[0].length );
          Severity: Major
          Found in app/lib/angular-sanitize/angular-sanitize.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                    if ( match ) {
                      html = html.replace( match[0] , '');
                      chars = false;
                    }
            Severity: Major
            Found in app/lib/angular-sanitize/angular-sanitize.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( match ) {
                        html = html.substring( match[0].length );
                        match[0].replace( START_TAG_REGEXP, parseStartTag );
                        chars = false;
                      }
              Severity: Minor
              Found in app/lib/angular-sanitize/angular-sanitize.js and 1 other location - About 45 mins to fix
              app/lib/angular-sanitize/angular-sanitize.js on lines 270..274

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( match ) {
                        html = html.substring( match[0].length );
                        match[0].replace( END_TAG_REGEXP, parseEndTag );
                        chars = false;
                      }
              Severity: Minor
              Found in app/lib/angular-sanitize/angular-sanitize.js and 1 other location - About 45 mins to fix
              app/lib/angular-sanitize/angular-sanitize.js on lines 280..284

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status