Sign upLogin

ari/jobsworth

View on GitHub
Star
app/assets/javascripts/filter.js

Summary

Maintainability
F
3 days
Test Coverage

Function Filter has 176 lines of code (exceeds 25 allowed). Consider refactoring.
Open

jobsworth.Filter = (function ($) {
  function Filter() {
    this.init();
    this.bind();
  }
Severity: Major
Found in app/assets/javascripts/filter.js - About 7 hrs to fix

    Function Filter has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

    jobsworth.Filter = (function ($) {
  function Filter() {
    this.init();
    this.bind();
  }
    Severity: Minor
    Found in app/assets/javascripts/filter.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function bind has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Filter.prototype.bind = function () {
    var self = this;

    // the user/client search box
    $(".search_filter").focus(function () {
    Severity: Minor
    Found in app/assets/javascripts/filter.js - About 1 hr to fix

      Function actionFilterClick has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Filter.prototype.actionFilterClick = function (link) {
    var sender = $(link);
    var tf_id = sender.parent().parent().attr("id").split("_")[1];
    
    if (sender.hasClass('do_hide') || sender.hasClass('do_show')) {
      Severity: Minor
      Found in app/assets/javascripts/filter.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        jQuery(document).ready(function () {
  jQuery("#tags-collapsable-sidepanel-button").on('click', function () {
    if (store.get('tags-collapsable-sidepanel-button') == 'h') {
      jQuery("#tags-collapsable-sidepanel-button").addClass('panel-open');
      jQuery("#tags-collapsable-sidepanel-button").removeClass('panel-collapsed');
        Severity: Major
        Found in app/assets/javascripts/filter.js and 1 other location - About 7 hrs to fix
        app/assets/javascripts/filter.js on lines 251..266

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 175.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        jQuery(document).ready(function () {
  jQuery("#task-filters-collapsable-sidepanel-button").on('click', function () {
    if (store.get('task-filters-collapsable-sidepanel-button') == 'h') {
      jQuery("#task-filters-collapsable-sidepanel-button").addClass('panel-open');
      jQuery("#task-filters-collapsable-sidepanel-button").removeClass('panel-collapsed');
        Severity: Major
        Found in app/assets/javascripts/filter.js and 1 other location - About 7 hrs to fix
        app/assets/javascripts/filter.js on lines 234..249

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 175.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              if (typeName && typeName.length > 0) {
        filterKeys.append('<input type="hidden" name="' + typeName + '" value="' + typeValue + '"/>');
      }
        Severity: Minor
        Found in app/assets/javascripts/filter.js and 2 other locations - About 35 mins to fix
        app/assets/javascripts/filter.js on lines 143..145
        app/assets/javascripts/filter.js on lines 146..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              if (reversedName && reversedName.length > 0) {
        filterKeys.append('<input type="hidden" name="' + reversedName + '" value="' + reversedVal + '"/>');
      }
        Severity: Minor
        Found in app/assets/javascripts/filter.js and 2 other locations - About 35 mins to fix
        app/assets/javascripts/filter.js on lines 140..142
        app/assets/javascripts/filter.js on lines 143..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              if (columnName && columnName.length > 0) {
        filterKeys.append('<input type="hidden" name="' + columnName + '" value="' + columnValue + '"/>');
      }
        Severity: Minor
        Found in app/assets/javascripts/filter.js and 2 other locations - About 35 mins to fix
        app/assets/javascripts/filter.js on lines 140..142
        app/assets/javascripts/filter.js on lines 146..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status