Sign upLogin

arsduo/koala

View on GitHub
Star

Showing 24 of 26 total issues

Method set_app_restrictions has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def set_app_restrictions(app_id, restrictions_hash, args = {}, options = {}, &block)
Severity: Minor
Found in lib/koala/api/graph_api_methods.rb - About 35 mins to fix

    Method process_binary_args has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def process_binary_args
          # collect binary files
          @args.each_pair do |key, value|
            if HTTPService::UploadableIO.binary_content?(value)
              @files ||= {}
    Severity: Minor
    Found in lib/koala/api/batch_operation.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method path has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def path
        # if an api_version is specified and the path does not already contain
        # one, prepend it to the path
        api_version = raw_options[:api_version] || Koala.config.api_version
        if api_version && !path_contains_api_version?
    Severity: Minor
    Found in lib/koala/http_service/request.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def initialize(options = {})
        @app_id = options[:app_id] || Koala.config.app_id
        @app_access_token = options[:app_access_token] || Koala.config.app_access_token
        @secret = options[:secret] || Koala.config.app_secret
        unless @app_id && (@app_access_token || @secret) # make sure we have what we need
    Severity: Minor
    Found in lib/koala/realtime_updates.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language