Sign upLogin

asennikov/ember-g-map

View on GitHub
Star
addon/components/g-map-route.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function updateRoute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  updateRoute() {
    const service = this.get('directionsService');
    const renderer = this.get('directionsRenderer');
    const originLat = this.get('originLat');
    const originLng = this.get('originLng');
Severity: Minor
Found in addon/components/g-map-route.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

        if (isPresent(service) && isPresent(renderer)
      && isPresent(originLat) && isPresent(originLng)
      && isPresent(destinationLat) && isPresent(destinationLng)
      && (typeof FastBoot === 'undefined')) {
      const origin = new google.maps.LatLng(this.get('originLat'), this.get('originLng'));
    Severity: Major
    Found in addon/components/g-map-route.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        willDestroyElement() {
    const renderer = this.get('directionsRenderer');
    if (isPresent(renderer)) {
      renderer.setMap(null);
    }
      Severity: Minor
      Found in addon/components/g-map-route.js and 2 other locations - About 30 mins to fix
      addon/components/g-map-marker.js on lines 96..101
      addon/components/g-map-polyline.js on lines 63..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status