Sign upLogin

atk4/ui

View on GitHub
Star
public/external/@shopify/draggable/build/umd/index.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function applyMemberDec has 11 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function applyMemberDec(e, t, r, a, n, i, s, o, c, l, u) {
Severity: Major
Found in public/external/@shopify/draggable/build/umd/index.js - About 1 hr to fix

Function memberDec has 11 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function memberDec(e, t, r, a, n, i, s, o, c, l, u) {
Severity: Major
Found in public/external/@shopify/draggable/build/umd/index.js - About 1 hr to fix

Function _applyDecs2305 has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function _applyDecs2305(e, t, r, a, n, i) {
Severity: Minor
Found in public/external/@shopify/draggable/build/umd/index.js - About 45 mins to fix

Avoid too many return statements within this function.
Open

        return false;
Severity: Major
Found in public/external/@shopify/draggable/build/umd/index.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return value(currentNode);
Severity: Major
Found in public/external/@shopify/draggable/build/umd/index.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return [];
Severity: Major
Found in public/external/@shopify/draggable/build/umd/index.js - About 30 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if (this.options.handle && event.target && !closest(event.target, this.options.handle)) {
        return;
      }
Severity: Minor
Found in public/external/@shopify/draggable/build/umd/index.js and 1 other location - About 35 mins to fix
public/external/@shopify/draggable/build/umd/index.js on lines 293..295

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if (this.options.handle && event.target && !closest(event.target, this.options.handle)) {
        return;
      }
Severity: Minor
Found in public/external/@shopify/draggable/build/umd/index.js and 1 other location - About 35 mins to fix
public/external/@shopify/draggable/build/umd/index.js on lines 479..481

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status