Sign upLogin

atk4/ui

View on GitHub
Star
src/Form/Control/TreeItemSelector.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$j'.
Open

        $this->cb = JsCallback::addTo($this)->set(function (Jquery $j, $data) use ($fx) {
Severity: Minor
Found in src/Form/Control/TreeItemSelector.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Atk4\Ui\View' in method 'init'.
Open

        $this->itemSelector = View::addTo($this, ['template' => $this->itemSelectorTemplate]);
Severity: Minor
Found in src/Form/Control/TreeItemSelector.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $cb. Configured minimum length is 3.
Open

    private $cb;
Severity: Minor
Found in src/Form/Control/TreeItemSelector.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $fx. Configured minimum length is 3.
Open

    public function onItem(\Closure $fx): void
Severity: Minor
Found in src/Form/Control/TreeItemSelector.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Line exceeds 120 characters; contains 128 characters
Open

        $this->addClass(['ui', 'vertical', 'segment', 'basic', $this->loaderCssName])->setStyle(['padding' => '0px!important']);
Severity: Minor
Found in src/Form/Control/TreeItemSelector.php by phpcodesniffer

Line exceeds 120 characters; contains 243 characters
Open

            $this->itemSelectorTemplate = new HtmlTemplate('<div class="ui list" style="margin-left: 16px;" {$attributes}><atk-tree-item-selector v-bind="initData"></atk-tree-item-selector><div class="ui hidden divider"></div>{$Input}</div>');
Severity: Minor
Found in src/Form/Control/TreeItemSelector.php by phpcodesniffer

Line exceeds 120 characters; contains 124 characters
Open

        return $this->getApp()->uiPersistence->typecastSaveField($this->entityField->getField(), $this->entityField->get());
Severity: Minor
Found in src/Form/Control/TreeItemSelector.php by phpcodesniffer

There are no issues that match your filters.

Category
Status