Sign upLogin

atk4/ui

View on GitHub
Star
src/Table/Column/FilterModel/TypeDate.php

Summary

Maintainability
C
1 day
Test Coverage

Missing class import via use statement (line '122', column '29').
Open

                $date = new \DateTime('+' . $this->get('number_days') . ' days');
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDate.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '126', column '45').
Open

                $date = $dateModifier ? new \DateTime($dateModifier) : null;
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDate.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '117', column '29').
Open

                $date = new \DateTime('-' . $this->get('number_days') . ' days');
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDate.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    #[\Override]
    protected function init(): void
    {
        parent::init();
Severity: Major
Found in src/Table/Column/FilterModel/TypeDate.php and 1 other location - About 1 day to fix
src/Table/Column/FilterModel/TypeDatetime.php on lines 13..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 283.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid variables with short names like $d1. Configured minimum length is 3.
Open

                    $d1 = $this->getDate($filter['value']);
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDate.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $d2. Configured minimum length is 3.
Open

                    $d2 = $this->getDate($filter['range']);
Severity: Minor
Found in src/Table/Column/FilterModel/TypeDate.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status