Sign upLogin

atk4/ui

View on GitHub
Star
src/UserAction/ModalExecutor.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Atk4\Ui\Loader' in method 'afterActionInit'.
Open

        $this->loader = Loader::addTo($this, ['shim' => $this, 'loadEvent' => false]);
Severity: Minor
Found in src/UserAction/ModalExecutor.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Atk4\Ui\Js\JsBlock' in method 'jsGetExecute'.
Open

            JsBlock::fromHookResult($this->hook(BasicExecutor::HOOK_AFTER_EXECUTE, [$obj, $id]) // @phpstan-ignore-line
                ?: ($success ?? new JsToast('Success' . (is_string($obj) ? (': ' . $obj) : '')))),
Severity: Minor
Found in src/UserAction/ModalExecutor.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    protected function jsGetExecute($obj, $id): JsBlock
Severity: Minor
Found in src/UserAction/ModalExecutor.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Opening brace should be on a new line
Open

    protected function initExecutor(): void {}
Severity: Minor
Found in src/UserAction/ModalExecutor.php by phpcodesniffer

Closing brace must be on a line by itself
Open

    protected function initExecutor(): void {}
Severity: Minor
Found in src/UserAction/ModalExecutor.php by phpcodesniffer

There are no issues that match your filters.

Category
Status