Sign upLogin

atom/atom

View on GitHub
Star
src/main-process/squirrel-update.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function addCommandsToPath has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const addCommandsToPath = callback => {
  const atomCmdName = execName.replace('.exe', '.cmd');
  const apmCmdName = atomCmdName.replace('atom', 'apm');
  const atomShName = execName.replace('.exe', '');
  const apmShName = atomShName.replace('atom', 'apm');
Severity: Major
Found in src/main-process/squirrel-update.js - About 2 hrs to fix

    Function handleStartupEvent has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.handleStartupEvent = squirrelCommand => {
  switch (squirrelCommand) {
    case '--squirrel-install':
      createShortcuts(['Desktop', 'StartMenu'], () =>
        addCommandsToPath(() =>
    Severity: Minor
    Found in src/main-process/squirrel-update.js - About 1 hr to fix

      Function installCommands has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const installCommands = callback => {
    const atomCommandPath = path.join(binFolder, atomCmdName);
    const relativeAtomPath = path.relative(
      binFolder,
      path.join(appFolder, 'resources', 'cli', 'atom.cmd')
      Severity: Minor
      Found in src/main-process/squirrel-update.js - About 1 hr to fix

        Function removeCommandsFromPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const removeCommandsFromPath = callback =>
  WinPowerShell.getPath((error, pathEnv) => {
    if (error != null) {
      return callback(error);
    }
        Severity: Minor
        Found in src/main-process/squirrel-update.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status