Sign upLogin

atomantic/hapi-auth-header

View on GitHub
Star

Showing 5 of 5 total issues

Function plugin has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

const plugin = (server, options) => {
    Hoek.assert(options, 'Missing auth-header strategy options');
    Hoek.assert(typeof options.validateFunc === 'function', 'options.validate must be an async validation function in the format (tokens)');

    const settings = Hoek.clone(options);
Severity: Minor
Found in lib/index.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function plugin has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const plugin = (server, options) => {
    Hoek.assert(options, 'Missing auth-header strategy options');
    Hoek.assert(typeof options.validateFunc === 'function', 'options.validate must be an async validation function in the format (tokens)');

    const settings = Hoek.clone(options);
Severity: Minor
Found in lib/index.js - About 1 hr to fix

    Function authenticate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            authenticate: async (request, h) => {
            let req = request.raw.req;
            let authorization = req.headers.authorization;
            let tokens = {};
            // no authorization header at all!
    Severity: Minor
    Found in lib/index.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                      return h.unauthenticated(Boom.badImplementation('Bad credentials received for Bearer auth validation'));
      Severity: Major
      Found in lib/index.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return h.authenticated({credentials: credentials});
        Severity: Major
        Found in lib/index.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language