atsid/circuits-js

View on GitHub
js/ServiceMethod.js

Summary

Maintainability
C
1 day
Test Coverage

Function invoke has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            invoke: function (params, plugins) {
                logger.debug("Calling service method: " + this.name + " with params", params);

                var that = this,
                    provider = this.provider,
Severity: Major
Found in js/ServiceMethod.js - About 2 hrs to fix

    Function processResponse has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                processResponse: function (statusCode, data, plugins, ioArgs) {
                    var isList = this.reader.isListResponse(this.name),
                    //TODO: "any" is JSONSchema default if no type is defined. this should come through a model though so we aren't tacking it on everywhere
                        returnType = this.reader.getResponseSchema(this.name).type || "any", //this could fail if there is no "returns" block on the method
                        payload,
    Severity: Minor
    Found in js/ServiceMethod.js - About 1 hr to fix

      Function processRequest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  processRequest: function (payload, plugins, ioArgs) {
                      var writePayload = payload || "", intermediate, that = this;
      
                      // Very simiplistic payload type coercion
                      if (this.requestPayloadName && !payload[this.requestPayloadName]) {
      Severity: Minor
      Found in js/ServiceMethod.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (util.isArray(writePayload)) {
                                writePayload.forEach(function (item, idx) {
                                    intermediate = plugin.fn.call(plugin.scope || plugin, item, that);
                                    writePayload[idx] = intermediate || writePayload[idx];
                                }, that);
        Severity: Major
        Found in js/ServiceMethod.js and 1 other location - About 1 hr to fix
        js/ServiceMethod.js on lines 240..248

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                    if (isList) {
                                        payload.some(function (item, idx) {
                                            intermediate = plugin.fn.call(plugin.scope || plugin, item, that);
                                            payload[idx] = intermediate || payload[idx];
                                        }, that);
        Severity: Major
        Found in js/ServiceMethod.js and 1 other location - About 1 hr to fix
        js/ServiceMethod.js on lines 170..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status