attentiveness/reading

View on GitHub

Showing 8 of 16 total issues

Function render has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { params } = this.props.navigation.state;
    return (
      <SafeAreaView style={styles.container}>
        <Modal
Severity: Minor
Found in app/pages/ItemDetail/WebViewPage.js - About 1 hr to fix

    Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
        const { params } = this.props.navigation.state;
        if (params !== undefined && params.isFirst) {
          return (
            <View style={styles.container}>
    Severity: Minor
    Found in app/pages/Category/Category.js - About 1 hr to fix

      Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render() {
          const { read } = this.props;
          const content = this.state.typeIds.map((typeId) => {
            if (this.state.typeList === null) {
              return null;
      Severity: Minor
      Found in app/pages/MainPage/Main.js - About 1 hr to fix

        Function request has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const request = (url, method, body) => {
          let isOk;
          return new Promise((resolve, reject) => {
            fetch(getUrl(url), {
              method,
        Severity: Minor
        Found in app/utils/RequestUtil.js - About 1 hr to fix

          Function componentDidMount has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            componentDidMount() {
              const { readActions } = this.props;
              DeviceEventEmitter.addListener('changeCategory', (typeIds) => {
                typeIds.forEach((typeId) => {
                  readActions.requestArticleList(false, true, typeId);
          Severity: Minor
          Found in app/pages/MainPage/Main.js - About 1 hr to fix

            Function requestArticleList has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              isRefreshing,
              loading,
              typeId,
              isLoadMore,
              page
            Severity: Minor
            Found in app/sagas/read.js - About 35 mins to fix

              Function requestArticleList has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                isRefreshing,
                loading,
                typeId,
                isLoadMore,
                page = 1
              Severity: Minor
              Found in app/actions/read.js - About 35 mins to fix

                Function componentWillReceiveProps has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  componentWillReceiveProps(nextProps) {
                    const { read } = this.props;
                    if (
                      read.isLoadMore &&
                      !nextProps.read.isLoadMore &&
                Severity: Minor
                Found in app/pages/MainPage/Main.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language