attester/attester

View on GitHub
lib/test-server/test-server.js

Summary

Maintainability
C
1 day
Test Coverage

File test-server.js has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright 2012 Amadeus s.a.s.
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
Severity: Minor
Found in lib/test-server/test-server.js - About 5 hrs to fix

    Function TestServer has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var TestServer = function (config, logger) {
        this.logger = new Logger("TestServer", logger);
        this.config = config;
        var app = connect();
        app.use(compression());
    Severity: Minor
    Found in lib/test-server/test-server.js - About 1 hr to fix

      Function routeCoverage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var routeCoverage = function (req, res, next) {
          var testServer = this;
          var match = /\/([0-9]+)\/([0-9]+)/.exec(req.path);
          var campaignId;
          var taskId;
      Severity: Minor
      Found in lib/test-server/test-server.js - About 1 hr to fix

        Function getStatus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        TestServer.prototype.getStatus = function () {
            return {
                slaves: this.slaves.map(function (slave) {
                    return {
                        address: slave.address,
        Severity: Minor
        Found in lib/test-server/test-server.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              app.use('/__attester__', template.bind({
                  data: this,
                  page: "/status.html",
                  path: path.join(__dirname, "client", "status.html")
              }));
          Severity: Minor
          Found in lib/test-server/test-server.js and 1 other location - About 35 mins to fix
          lib/test-server/test-server.js on lines 247..251

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              app.use('/__attester__', template.bind({
                  data: this,
                  page: "/slave.html",
                  path: path.join(__dirname, "client", "slave.html")
              }));
          Severity: Minor
          Found in lib/test-server/test-server.js and 1 other location - About 35 mins to fix
          lib/test-server/test-server.js on lines 242..246

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status