Sign upLogin

attogram/attogram-database

View on GitHub
Star

Showing 25 of 7,594 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                        if(($typeAffinity=="TEXT" || $typeAffinity=="NONE") && !$null)
                            $query_vals .= $db->quote($value);
                        elseif(($typeAffinity=="INTEGER" || $typeAffinity=="REAL"|| $typeAffinity=="NUMERIC") && $value=="")
                            $query_vals .= "NULL";
                        elseif($null)
Severity: Major
Found in admin_actions/db-admin.php and 1 other location - About 1 hr to fix
admin_actions/db-admin.php on lines 1290..1297

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    if(!$all_default)
                    {
                        $query_cols = substr($query_cols, 0, strlen($query_cols)-1);
                        $query_vals = substr($query_vals, 0, strlen($query_vals)-1);
Severity: Major
Found in admin_actions/db-admin.php and 1 other location - About 1 hr to fix
admin_actions/db-admin.php on lines 1303..1311

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        case "table_drop":
            echo "<form action='?action=table_drop&amp;confirm=1' method='post'>";
            echo "<input type='hidden' name='tablename' value='".htmlencode($target_table)."'/>";
            echo "<div class='confirm'>";
            echo sprintf($lang['ques_drop'], htmlencode($target_table))."<br/><br/>";
Severity: Major
Found in admin_actions/db-admin.php and 2 other locations - About 1 hr to fix
admin_actions/db-admin.php on lines 2038..2046
admin_actions/db-admin.php on lines 2060..2068

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        case "table_empty":
            echo "<form action='?action=table_empty&amp;confirm=1' method='post'>";
            echo "<input type='hidden' name='tablename' value='".htmlencode($target_table)."'/>";
            echo "<div class='confirm'>";
            echo sprintf($lang['ques_empty'], htmlencode($target_table))."<br/><br/>";
Severity: Major
Found in admin_actions/db-admin.php and 2 other locations - About 1 hr to fix
admin_actions/db-admin.php on lines 2049..2057
admin_actions/db-admin.php on lines 2060..2068

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        case "view_drop":
            echo "<form action='?action=view_drop&amp;confirm=1' method='post'>";
            echo "<input type='hidden' name='viewname' value='".htmlencode($target_table)."'/>";
            echo "<div class='confirm'>";
            echo sprintf($lang['ques_drop_view'], htmlencode($target_table))."<br/><br/>";
Severity: Major
Found in admin_actions/db-admin.php and 2 other locations - About 1 hr to fix
admin_actions/db-admin.php on lines 2038..2046
admin_actions/db-admin.php on lines 2049..2057

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language