Sign upLogin

attogram/attogram-user

View on GitHub
Star

Showing 3 of 56 total issues

Method login has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function login(\Psr\Log\LoggerInterface $log, \Attogram\AttogramDatabaseInterface $database)
    {
        if (!isset($_POST['u']) || !isset($_POST['p']) || !$_POST['u'] || !$_POST['p']) {
            $log->error('LOGIN: missing username or password');
            return false;
Severity: Minor
Found in includes/AttogramUser.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in includes/AttogramUser.php - About 30 mins to fix

      Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function login(\Psr\Log\LoggerInterface $log, \Attogram\AttogramDatabaseInterface $database)
    {
        if (!isset($_POST['u']) || !isset($_POST['p']) || !$_POST['u'] || !$_POST['p']) {
            $log->error('LOGIN: missing username or password');
            return false;
      Severity: Minor
      Found in includes/AttogramUser.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language