Sign upLogin

aureooms/js-integer

View on GitHub
Star
src/IntegerRing.js

Summary

Maintainability
B
4 hrs
Test Coverage
A
100%

Function from has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    from(object, base = undefined, is_negative = 0) {
        if (object === null || object === undefined) return this.$0();

        switch (object.constructor.prototype) {
            case Number.prototype:
Severity: Minor
Found in src/IntegerRing.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function from has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    from(object, base = undefined, is_negative = 0) {
        if (object === null || object === undefined) return this.$0();

        switch (object.constructor.prototype) {
            case Number.prototype:
Severity: Minor
Found in src/IntegerRing.js - About 1 hr to fix

    Function from_string has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        from_string(string, base = 10, is_negative = 0) {
        if (string.length === 0)
            throw new ValueError(
                'IntegerRing#from_string cannot parse empty string.',
            );
    Severity: Minor
    Found in src/IntegerRing.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                    return new Integer(
                    object._base,
                    object._is_negative ^ is_negative,
                    object._limbs,
                );
    Severity: Major
    Found in src/IntegerRing.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return this.from_number(Number(object), is_negative);
      Severity: Major
      Found in src/IntegerRing.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status