autolab/Autolab

View on GitHub
app/assets/javascripts/SlickGrid/2.02/slick.dataview.js

Summary

Maintainability
F
1 wk
Test Coverage

Function DataView has 635 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function DataView(options) {
    var self = this;

    var defaults = {
      groupItemMetadataProvider: null,
Severity: Major
Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js - About 3 days to fix

    File slick.dataview.js has 734 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function ($) {
      $.extend(true, window, {
        Slick: {
          Data: {
            DataView: DataView,
    Severity: Major
    Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js - About 1 day to fix

      Consider simplifying this complex logical expression.
      Open

                if ((groupingGetter && (eitherIsNonData = (item.__nonDataRow) || (r.__nonDataRow)) &&
                    item.__group !== r.__group ||
                    item.__updated ||
                    item.__group && !item.equals(r))
                    || (aggregators && eitherIsNonData &&
      Severity: Critical
      Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js - About 3 hrs to fix

        Function syncGridCellCssStyles has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function syncGridCellCssStyles(grid, key) {
              var hashById;
              var inHandler;
        
              // since this method can be called after the cell styles have been set,
        Severity: Minor
        Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js - About 1 hr to fix

          Function getRowDiffs has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function getRowDiffs(rows, newRows) {
                var item, r, eitherIsNonData, diff = [];
                var from = 0, to = newRows.length;
          
                if (refreshHints && refreshHints.ignoreDiffsBefore) {
          Severity: Minor
          Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js - About 1 hr to fix

            Function compileFilterWithCaching has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function compileFilterWithCaching() {
                  var filterInfo = getFunctionInfo(filter);
            
                  var filterBody = filterInfo.body
                      .replace(/return false[;}]/gi, "{ continue _coreloop; }")
            Severity: Minor
            Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                function MaxAggregator(field) {
                  this.field_ = field;
              
                  this.init = function () {
                    this.max_ = null;
              Severity: Major
              Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js and 1 other location - About 1 day to fix
              app/assets/javascripts/SlickGrid/2.02/slick.dataview.js on lines 836..858

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 209.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                function MinAggregator(field) {
                  this.field_ = field;
              
                  this.init = function () {
                    this.min_ = null;
              Severity: Major
              Found in app/assets/javascripts/SlickGrid/2.02/slick.dataview.js and 1 other location - About 1 day to fix
              app/assets/javascripts/SlickGrid/2.02/slick.dataview.js on lines 860..882

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 209.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status