Sign upLogin

autolab/Autolab

View on GitHub
Star
app/assets/javascripts/handin.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function enableSubmit has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function enableSubmit() {
  var checkbox = document.getElementById("integrity_checkbox");
  var tab = $(".submission-panel .ui.tab.active").attr('id');
  var fileSelector = $("#handin_show_assessment input[type='file']").get(0);
  if (tab === "github_tab") {
Severity: Minor
Found in app/assets/javascripts/handin.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function showFiles has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function showFiles() {
  var fileSelector = $("#handin_show_assessment input[type='file']").get(0);
  var file = fileSelector.files[0];
  $("#handin-file-name").text(file.name);
Severity: Minor
Found in app/assets/javascripts/handin.js - About 1 hr to fix

    Function enableSubmit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function enableSubmit() {
  var checkbox = document.getElementById("integrity_checkbox");
  var tab = $(".submission-panel .ui.tab.active").attr('id');
  var fileSelector = $("#handin_show_assessment input[type='file']").get(0);
  if (tab === "github_tab") {
    Severity: Minor
    Found in app/assets/javascripts/handin.js - About 1 hr to fix

      Function showFiles has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function showFiles() {
  var fileSelector = $("#handin_show_assessment input[type='file']").get(0);
  var file = fileSelector.files[0];
  $("#handin-file-name").text(file.name);
      Severity: Minor
      Found in app/assets/javascripts/handin.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status