Sign upLogin

avadordi/mass-spectrometry

View on GitHub
Star

Showing 25 of 29 total issues

Avoid deeply nested control flow statements.
Open

                        if (!paramNameSlice.length) {
                            paramNameSlice = paramName;
                        }
Severity: Major
Found in app/assets/javascripts/z.jquery.fileupload.js - About 45 mins to fix

    Method start_ssh has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def start_ssh

    rand_dir = SecureRandom.uuid
    mass_datum = MassDatum.find(self.mass_data_id)
    mass_param = MassParam.find(self.mass_params_id)
    Severity: Minor
    Found in app/models/result.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method assign_model_id has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def assign_model_id(id, model_id)
    current_result = current_user.current_result
    if current_result
      if model_id == :mass_data_id then current_result.mass_data_id = id else current_result.mass_params_id = id end
      current_result.save
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method finish has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def finish
    # final results
    if !current_user.current_result
      #error
      flash[:warning] = "Please upload files to run."
    Severity: Minor
    Found in app/controllers/results_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function s3_upload_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    var s3_upload_file = function(url, formData) {
  $('.directUpload').find("input:file").each(function(i, elem) {

    var fileInput    = $(elem);
    var form         = $('.directUpload').find('form:first');
    Severity: Minor
    Found in app/assets/javascripts/s3.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language