Sign upLogin

awsmug/torro-forms

View on GitHub
Star
assets/src/js/admin-form-builder/app.js

Summary

Maintainability
F
2 wks
Test Coverage

Function init has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        init: function() {
            if ( ! this.$el.length ) {
                console.error( i18n.couldNotInitCanvas );
                return;
            }
Severity: Major
Found in assets/src/js/admin-form-builder/app.js - About 2 hrs to fix

    Function setupInitialData has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            setupInitialData: function( form ) {
            var container, element, elementChoice, elementSetting, elementParents, i;

            if ( ! _.contains( initialized, this.instanceCount ) ) {
                return;
    Severity: Major
    Found in assets/src/js/admin-form-builder/app.js - About 2 hrs to fix

      File app.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      window.torro = window.torro || {};

( function( torro, $, _, i18n ) {
    'use strict';
      Severity: Minor
      Found in assets/src/js/admin-form-builder/app.js - About 2 hrs to fix

        Function success has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                                success: function( elementTypes ) {
                            this.elementTypes = torro.Builder.ElementTypes.fromApiCollection( elementTypes );

                            if ( 'auto-draft' !== $( '#original_post_status' ).val() ) {
                                ( new torro.api.models.Form({
        Severity: Minor
        Found in assets/src/js/admin-form-builder/app.js - About 1 hr to fix

          Function askConfirmation has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              torro.askConfirmation = function( message, successCallback ) {
        var $dialog = $( '<div />' );

        $dialog.html( message );
          Severity: Minor
          Found in assets/src/js/admin-form-builder/app.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                        if ( container ) {
                                container.elements.add( element );

                                elementParents[ element.id ] = element.container_id;
                            }
            Severity: Major
            Found in assets/src/js/admin-form-builder/app.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          for ( i = 0; i < form._embedded.element_choices[0].length; i++ ) {
                                elementChoice = form._embedded.element_choices[0][ i ];

                                if ( elementParents[ elementChoice.element_id ] ) {
                                    container = this.form.containers.get( elementParents[ elementChoice.element_id ] );
              Severity: Major
              Found in assets/src/js/admin-form-builder/app.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            for ( i = 0; i < form._embedded.element_settings[0].length; i++ ) {
                                elementSetting = form._embedded.element_settings[0][ i ];

                                if ( elementParents[ elementSetting.element_id ] ) {
                                    container = this.form.containers.get( elementParents[ elementSetting.element_id ] );
                Severity: Major
                Found in assets/src/js/admin-form-builder/app.js - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  ( function( torro, $, _, i18n ) {
    'use strict';

    var instanceCount = 0,
        initialized = [],
                  Severity: Major
                  Found in assets/src/js/admin-form-builder/app.js and 1 other location - About 2 wks to fix
                  assets/dist/js/admin-form-builder.js on lines 7..422

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 2683.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status