Sign upLogin

azach/rules

View on GitHub
Star

Showing 3 of 3 total issues

Method evaluate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def evaluate(attributes = {})
      return true unless rules.any?
      if evaluation_logic == 'any'
        !!rules.detect { |rule| rule.evaluate(attributes) }
      else
Severity: Minor
Found in lib/rules/rule_set.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method evaluate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def evaluate(lhs, rhs = nil)
        raise 'Unknown evaluation method' unless evaluation_method

        begin
          requires_rhs? ? evaluation_method.call(lhs, rhs) : evaluation_method.call(lhs)
Severity: Minor
Found in lib/rules/evaluators/evaluator.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cast has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.cast(value, type)
      return value unless type
      case type
      when :date
        Date.parse(value.to_s)
Severity: Minor
Found in lib/rules/parameters/parameter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language