Sign upLogin

babel/babel

View on GitHub
Star
packages/babel-plugin-transform-parameters/src/rest.js

Summary

Maintainability
D
2 days
Test Coverage

Function ReferencedIdentifier has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  ReferencedIdentifier(path, state) {
    const { node } = path;

    // we can't guarantee the purity of arguments
    if (node.name === "arguments") {
Severity: Minor
Found in packages/babel-plugin-transform-parameters/src/rest.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convertFunctionRest has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function convertFunctionRest(path) {
  const { node, scope } = path;
  if (!hasRest(node)) return false;

  let rest = node.params.pop().argument;
Severity: Major
Found in packages/babel-plugin-transform-parameters/src/rest.js - About 3 hrs to fix

    File rest.js has 253 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { template, types as t } from "@babel/core";

const buildRest = template(`
  for (var LEN = ARGUMENTS.length,
           ARRAY = new Array(ARRAY_LEN),
    Severity: Minor
    Found in packages/babel-plugin-transform-parameters/src/rest.js - About 2 hrs to fix

      Function ReferencedIdentifier has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ReferencedIdentifier(path, state) {
    const { node } = path;

    // we can't guarantee the purity of arguments
    if (node.name === "arguments") {
      Severity: Minor
      Found in packages/babel-plugin-transform-parameters/src/rest.js - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

              if (parentPath.isMemberExpression({ object: node })) {
        const grandparentPath = parentPath.parentPath;

        const argsOptEligible =
          !state.deopted &&
        Severity: Critical
        Found in packages/babel-plugin-transform-parameters/src/rest.js - About 2 hrs to fix

          Function optimiseIndexGetter has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function optimiseIndexGetter(path, argsId, offset) {
  const offsetLiteral = t.numericLiteral(offset);
  let index;

  if (t.isNumericLiteral(path.parent.property)) {
          Severity: Minor
          Found in packages/babel-plugin-transform-parameters/src/rest.js - About 1 hr to fix

            Function convertFunctionRest has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            export default function convertFunctionRest(path) {
  const { node, scope } = path;
  if (!hasRest(node)) return false;

  let rest = node.params.pop().argument;
            Severity: Minor
            Found in packages/babel-plugin-transform-parameters/src/rest.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function optimiseIndexGetter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            function optimiseIndexGetter(path, argsId, offset) {
  const offsetLiteral = t.numericLiteral(offset);
  let index;

  if (t.isNumericLiteral(path.parent.property)) {
            Severity: Minor
            Found in packages/babel-plugin-transform-parameters/src/rest.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                      } else if (parentPath.node.property.name === "length") {
            // args.length
            state.candidates.push({ cause: "lengthGetter", path });
            return;
          }
            Severity: Major
            Found in packages/babel-plugin-transform-parameters/src/rest.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if (parentPath.get("property").isBaseType("number")) {
              state.candidates.push({ cause: "indexGetter", path });
              return;
            }
              Severity: Major
              Found in packages/babel-plugin-transform-parameters/src/rest.js - About 45 mins to fix

                Avoid too many return statements within this function.
                Open

                          return;
                Severity: Major
                Found in packages/babel-plugin-transform-parameters/src/rest.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    const loop = buildRest({
    ARGUMENTS: argsId,
    ARRAY_KEY: arrKey,
    ARRAY_LEN: arrLen,
    START: start,
                  Severity: Minor
                  Found in packages/babel-plugin-transform-parameters/src/rest.js and 1 other location - About 35 mins to fix
                  packages/babel-plugin-transform-computed-properties/src/index.js on lines 176..184

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status