backlogs/redmine_backlogs

View on GitHub
assets/javascripts/jquery/jquery.multiselect.js

Summary

Maintainability
D
2 days
Test Coverage

File jquery.multiselect.js has 492 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* jshint forin:true, noarg:true, noempty:true, eqeqeq:true, boss:true, undef:true, curly:true, browser:true, jquery:true */
/*
 * jQuery MultiSelect UI Widget 1.13
 * Copyright (c) 2012 Eric Hynds
 * Patched for redmine_backlogs: use selected attribute instead of this.selected for initialization
Severity: Minor
Found in assets/javascripts/jquery/jquery.multiselect.js - About 7 hrs to fix

    Function _bindEvents has 127 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _bindEvents: function(){
            var self = this, button = this.button;
    
            function clickHandler(){
                self[ self._isOpen ? 'close' : 'open' ]();
    Severity: Major
    Found in assets/javascripts/jquery/jquery.multiselect.js - About 5 hrs to fix

      Function refresh has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          refresh: function( init ){
              var el = this.element,
                  o = this.options,
                  menu = this.menu,
                  checkboxContainer = this.checkboxContainer,
      Severity: Major
      Found in assets/javascripts/jquery/jquery.multiselect.js - About 2 hrs to fix

        Function _create has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _create: function(){
                var el = this.element.hide(),
                    o = this.options;
        
                this.speed = $.fx.speeds._default; // default speed for effects
        Severity: Minor
        Found in assets/javascripts/jquery/jquery.multiselect.js - About 1 hr to fix

          Function open has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              open: function( e ){
                  var self = this,
                      button = this.button,
                      menu = this.menu,
                      speed = this.speed,
          Severity: Minor
          Found in assets/javascripts/jquery/jquery.multiselect.js - About 1 hr to fix

            Function _setOption has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _setOption: function( key, value ){
                    var menu = this.menu;
            
                    switch(key){
                        case 'header':
            Severity: Minor
            Found in assets/javascripts/jquery/jquery.multiselect.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      this.element
                          .find('option')
                          .each(function(){
                              if( !this.disabled && $.inArray(this.value, values) > -1 ){
                                  self._toggleState('selected', flag).call( this );
              Severity: Major
              Found in assets/javascripts/jquery/jquery.multiselect.js and 1 other location - About 2 hrs to fix
              assets/javascripts/jquery/jquery.multiselect.filter.js on lines 84..90

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 83.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status