balderdashy/waterline

Function replaceCollection has 241 lines of code (exceeds 25 allowed). Consider refactoring.

Open

module.exports = function replaceCollection(/* targetRecordIds?, collectionAttrName?, associatedIds?, explicitCbMaybe?, meta? */) {

  // Verify `this` refers to an actual Sails/Waterline model.
  verifyModelMethodContext(this);

File replace-collection.js has 251 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/**
 * Module dependencies
 */

var assert = require('assert');

Avoid too many return statements within this function.

Open

        if (query.targetRecordIds.length === 0) { return proceed(new Error('Consistency violation: No target record ids-- should never have been possible, because this query should have been halted when it was being forged at stage 2.')); }

Identical blocks of code found in 2 locations. Consider refactoring.

Open

          if (_.has(Object.getPrototypeOf(WLChild), 'junctionTable') && WLChild.junctionTable) {
            // Assumes the generated junction table will only ever have two foreign key
            // values. Should be safe for now and any changes would need to be made in
            // Waterline-Schema where a map could be formed anyway.
            _.each(WLChild.schema, function(wlsAttrDef, key) {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  (function _handleVariadicUsage(){

    // The metadata container, if one was provided.
    var _meta;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        try {
          assert.equal(schemaDef.collection.toLowerCase(), schemaDef.collection, '`schemaDef.collection` (identity) should have already been normalized before getting here!  But it was not: '+schemaDef.collection);
          assert.equal(schemaDef.referenceIdentity.toLowerCase(), schemaDef.referenceIdentity, '`schemaDef.referenceIdentity` (identity) should have already been normalized before getting here!  But it was not: '+schemaDef.referenceIdentity);
          assert.equal(Object.getPrototypeOf(WLChild).identity.toLowerCase(), Object.getPrototypeOf(WLChild).identity, '`Object.getPrototypeOf(WLChild).identity` (identity) should have already been normalized before getting here!  But it was not: '+Object.getPrototypeOf(WLChild).identity);
        } catch (e) { return proceed(e); }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

          if (_.has(Object.getPrototypeOf(WLChild), 'junctionTable') && WLChild.junctionTable) {
            // Assumes the generated junction table will only ever have two foreign key
            // values. Should be safe for now and any changes would need to be made in
            // Waterline-Schema where a map could be formed anyway.
            _.each(WLChild.schema, function(wlsAttrDef, key) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          _.each(query.targetRecordIds, function(targetId) {
            _.each(query.associatedIds, function(associatedId) {
              var record = {};
              record[parentReference] = targetId;
              record[childReference] = associatedId;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        try { assert.equal(query.using.toLowerCase(), query.using, '`query.using` (identity) should have already been normalized before getting here!  But it was not: '+query.using); } catch (e) { return proceed(e); }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

        if (schemaDef.referenceIdentity !== Object.getPrototypeOf(WLChild).identity) {
          manyToMany = true;
          WLChild = orm.collections[schemaDef.referenceIdentity];
        }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

        if (_.has(Object.getPrototypeOf(WLChild), 'throughTable') && _.keys(WLChild.throughTable).length) {
          manyToMany = true;
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        var modifiedMeta = _.extend({}, query.meta || {}, { skipAllLifecycleCallbacks: true });

• Read up
  Read up