Sign upLogin

balderdashy/waterline

View on GitHub
Star
lib/waterline/methods/stream.js

Summary

Maintainability
D
2 days
Test Coverage

Function stream has 194 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function stream( /* criteria?, eachRecordFn?, explicitCbMaybe?, meta?, moreQueryKeys? */ ) {

  // Verify `this` refers to an actual Sails/Waterline model.
  verifyModelMethodContext(this);
Severity: Major
Found in lib/waterline/methods/stream.js - About 7 hrs to fix

    Function _beginBatchMaybe has 112 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          function _beginBatchMaybe(next) {

        // 0   => 15
        // 15  => 15
        // 30  => 15
    Severity: Major
    Found in lib/waterline/methods/stream.js - About 4 hrs to fix

      Function _makeCallOrCallsToAppropriateIteratee has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                (function _makeCallOrCallsToAppropriateIteratee(proceed){

            // Check if the iteratee declares a callback parameter
            var seemsToExpectCallback = (function(){
              var fn = query.eachBatchFn || query.eachRecordFn;
      Severity: Major
      Found in lib/waterline/methods/stream.js - About 3 hrs to fix

        Function _eachRecordInBatch has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    async.eachSeries(batchOfRecords, function _eachRecordInBatch(record, next) {
              // Note that, if you try to call next() more than once in the iteratee, Waterline
              // logs a warning explaining what's up, ignoring all subsequent calls to next()
              // that occur after the first.
              var didIterateeAlreadyHalt;
        Severity: Minor
        Found in lib/waterline/methods/stream.js - About 1 hr to fix

          Function stream has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function stream( /* criteria?, eachRecordFn?, explicitCbMaybe?, meta?, moreQueryKeys? */ ) {

  // Verify `this` refers to an actual Sails/Waterline model.
  verifyModelMethodContext(this);
          Severity: Minor
          Found in lib/waterline/methods/stream.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (query.eachBatchFn.constructor.name === 'AsyncFunction') {
                  if (!seemsToExpectCallback) {
                    promiseMaybe = promiseMaybe.then(function(){
                      didIterateeAlreadyHalt = true;
                      proceed();
          Severity: Major
          Found in lib/waterline/methods/stream.js and 1 other location - About 2 hrs to fix
          lib/waterline/methods/stream.js on lines 431..444

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (query.eachRecordFn.constructor.name === 'AsyncFunction') {
                  if (!seemsToExpectCallback) {
                    promiseMaybe = promiseMaybe.then(function(){
                      didIterateeAlreadyHalt = true;
                      next();
          Severity: Major
          Found in lib/waterline/methods/stream.js and 1 other location - About 2 hrs to fix
          lib/waterline/methods/stream.js on lines 379..392

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status