Sign upLogin

balderdashy/waterline

View on GitHub
Star
lib/waterline/utils/query/process-all-records.js

Summary

Maintainability
F
3 days
Test Coverage

Function processAllRecords has 227 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function processAllRecords(records, meta, modelIdentity, orm) {
  // console.time('processAllRecords');


  if (!_.isArray(records)) {
Severity: Major
Found in lib/waterline/utils/query/process-all-records.js - About 1 day to fix

    Function _eachParentOrChildRecord has 215 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      eachRecordDeep(records, function _eachParentOrChildRecord(record, WLModel){

    // First, check the results to verify compliance with the adapter spec.,
    // as well as any issues related to stale data that might not have been
    // been migrated to keep up with the logical schema (`type`, etc. in
    Severity: Major
    Found in lib/waterline/utils/query/process-all-records.js - About 1 day to fix

      Function processAllRecords has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function processAllRecords(records, meta, modelIdentity, orm) {
  // console.time('processAllRecords');


  if (!_.isArray(records)) {
      Severity: Minor
      Found in lib/waterline/utils/query/process-all-records.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File process-all-records.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * Module dependencies
 */

var assert = require('assert');
      Severity: Minor
      Found in lib/waterline/utils/query/process-all-records.js - About 2 hrs to fix

        Avoid deeply nested control flow statements.
        Open

                else if (attrDef.autoCreatedAt || attrDef.autoUpdatedAt) {

          assert(!attrDef.allowNull, 'Timestamp attributes should never be defined with `allowNull:true`.  (This should have already been caught in wl-schema during ORM initialization!  Please report this at http://sailsjs.com/bugs)');

          // If there is no value defined on the record for this attribute...
        Severity: Major
        Found in lib/waterline/utils/query/process-all-records.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    if (_.isUndefined(record[attrName])) {
          }
          // If the value for this singular association came back as an array, then
          // that might be ok too-- it probably means that the association was populated.
          else if (_.isArray(record[attrName])) {
          Severity: Major
          Found in lib/waterline/utils/query/process-all-records.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              if (!_.isArray(records)) {
    throw new Error('Consistency violation: Expected `records` to be an array.  But instead, got: '+util.inspect(records,{depth:5})+'');
  }
            Severity: Minor
            Found in lib/waterline/utils/query/process-all-records.js and 1 other location - About 40 mins to fix
            lib/waterline/utils/query/private/build-usage-error.js on lines 159..161

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        console.warn('\n'+
              'An association in a result record has an unexpected data type.  Since `'+attrName+'` is\n'+
              'a singular (association), it should come back from Waterline as either:\n'+
              '• `null` (if not populated and set to null explicitly, or populated but orphaned)\n'+
              '• a dictionary (if successfully populated), or\n'+
            Severity: Minor
            Found in lib/waterline/utils/query/process-all-records.js and 1 other location - About 35 mins to fix
            lib/waterline/utils/query/forge-stage-two-query.js on lines 1001..1008

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status