bbatsov/rubocop

View on GitHub

Showing 644 of 684 total issues

File rubocop.rb has 753 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'English'

# fileutils is autoloaded by pathname,
# but must be explicitly loaded here for inclusion in `$LOADED_FEATURES`.
require 'fileutils'
Severity: Major
Found in lib/rubocop.rb - About 1 day to fix

    Class Base has 64 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Base # rubocop:disable Metrics/ClassLength
          extend RuboCop::AST::Sexp
          extend NodePattern::Macros
          extend ExcludeLimit
          include RuboCop::AST::Sexp
    Severity: Major
    Found in lib/rubocop/cop/base.rb - About 1 day to fix

      File options.rb has 521 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'optparse'
      require_relative 'arguments_env'
      require_relative 'arguments_file'
      
      module RuboCop
      Severity: Major
      Found in lib/rubocop/options.rb - About 1 day to fix

        File conditional_assignment.rb has 412 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module RuboCop
          module Cop
            module Style
              # Helper module to provide common methods to classes needed for the
              # ConditionalAssignment Cop.
        Severity: Minor
        Found in lib/rubocop/cop/style/conditional_assignment.rb - About 5 hrs to fix

          Class SpaceAroundKeyword has 43 methods (exceeds 20 allowed). Consider refactoring.
          Open

                class SpaceAroundKeyword < Base
                  extend AutoCorrector
          
                  MSG_BEFORE = 'Space before keyword `%<range>s` is missing.'
                  MSG_AFTER = 'Space after keyword `%<range>s` is missing.'
          Severity: Minor
          Found in lib/rubocop/cop/layout/space_around_keyword.rb - About 5 hrs to fix

            Class Runner has 42 methods (exceeds 20 allowed). Consider refactoring.
            Open

              class Runner # rubocop:disable Metrics/ClassLength
                # An exception indicating that the inspection loop got stuck correcting
                # offenses back and forth.
                class InfiniteCorrectionLoop < StandardError
                  attr_reader :offenses
            Severity: Minor
            Found in lib/rubocop/runner.rb - About 5 hrs to fix

              Class Config has 41 methods (exceeds 20 allowed). Consider refactoring.
              Open

                class Config
                  include PathUtil
                  include FileFinder
                  extend SimpleForwardable
              
              
              Severity: Minor
              Found in lib/rubocop/config.rb - About 5 hrs to fix

                Class BlockDelimiters has 40 methods (exceeds 20 allowed). Consider refactoring.
                Open

                      class BlockDelimiters < Base
                        include ConfigurableEnforcedStyle
                        include AllowedMethods
                        include AllowedPattern
                        include RangeHelp
                Severity: Minor
                Found in lib/rubocop/cop/style/block_delimiters.rb - About 5 hrs to fix

                  Class Registry has 40 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                      class Registry
                        include Enumerable
                  
                        def self.all
                          global.without_department(:Test).cops
                  Severity: Minor
                  Found in lib/rubocop/cop/registry.rb - About 5 hrs to fix

                    File runner.rb has 363 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require 'parallel'
                    
                    module RuboCop
                      # This class handles the processing of files, which includes dealing with
                      # formatters and letting cops inspect the files.
                    Severity: Minor
                    Found in lib/rubocop/runner.rb - About 4 hrs to fix

                      Class MethodCallWithArgsParentheses has 36 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                            class MethodCallWithArgsParentheses
                              # Style omit_parentheses
                              # rubocop:disable Metrics/ModuleLength, Metrics/CyclomaticComplexity
                              module OmitParentheses
                                include RangeHelp

                        Class RedundantCopDisableDirective has 34 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                              class RedundantCopDisableDirective < Base # rubocop:todo Metrics/ClassLength
                                include RangeHelp
                                extend AutoCorrector
                        
                                COP_NAME = 'Lint/RedundantCopDisableDirective'
                        Severity: Minor
                        Found in lib/rubocop/cop/lint/redundant_cop_disable_directive.rb - About 4 hrs to fix

                          Class IndentationWidth has 34 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                                class IndentationWidth < Base # rubocop:disable Metrics/ClassLength
                                  include EndKeywordAlignment
                                  include Alignment
                                  include CheckAssignment
                                  include AllowedPattern
                          Severity: Minor
                          Found in lib/rubocop/cop/layout/indentation_width.rb - About 4 hrs to fix

                            Method find_offense_message has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                            Open

                                    def find_offense_message(begin_node, node)
                                      return 'a keyword' if keyword_with_redundant_parentheses?(node)
                                      return 'a literal' if disallowed_literal?(begin_node, node)
                                      return 'a variable' if node.variable?
                                      return 'a constant' if node.const_type?
                            Severity: Minor
                            Found in lib/rubocop/cop/style/redundant_parentheses.rb - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Class CopsDocumentationGenerator has 29 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                            class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
                              include ::RuboCop::Cop::Documentation
                              CopData = Struct.new(
                                :cop, :description, :example_objects, :safety_objects, :see_objects, :config, keyword_init: true
                              )
                            Severity: Minor
                            Found in lib/rubocop/cops_documentation_generator.rb - About 3 hrs to fix

                              Class VariableForce has 29 methods (exceeds 20 allowed). Consider refactoring.
                              Open

                                  class VariableForce < Force # rubocop:disable Metrics/ClassLength
                                    VARIABLE_ASSIGNMENT_TYPE = :lvasgn
                                    REGEXP_NAMED_CAPTURE_TYPE = :match_with_lvasgn
                                    PATTERN_MATCH_VARIABLE_TYPE = :match_var
                                    VARIABLE_ASSIGNMENT_TYPES = [
                              Severity: Minor
                              Found in lib/rubocop/cop/variable_force.rb - About 3 hrs to fix

                                Class DisabledConfigFormatter has 29 methods (exceeds 20 allowed). Consider refactoring.
                                Open

                                    class DisabledConfigFormatter < BaseFormatter
                                      include PathUtil
                                
                                      HEADING = <<~COMMENTS
                                        # This configuration was generated by
                                Severity: Minor
                                Found in lib/rubocop/formatter/disabled_config_formatter.rb - About 3 hrs to fix

                                  Class RedundantParentheses has 29 methods (exceeds 20 allowed). Consider refactoring.
                                  Open

                                        class RedundantParentheses < Base
                                          include Parentheses
                                          extend AutoCorrector
                                  
                                          ALLOWED_NODE_TYPES = %i[and or send splat kwsplat].freeze
                                  Severity: Minor
                                  Found in lib/rubocop/cop/style/redundant_parentheses.rb - About 3 hrs to fix

                                    File arguments_forwarding.rb has 310 lines of code (exceeds 250 allowed). Consider refactoring.
                                    Open

                                    module RuboCop
                                      module Cop
                                        module Style
                                          # In Ruby 2.7, arguments forwarding has been added.
                                          #
                                    Severity: Minor
                                    Found in lib/rubocop/cop/style/arguments_forwarding.rb - About 3 hrs to fix

                                      Class HeredocArgumentClosingParenthesis has 28 methods (exceeds 20 allowed). Consider refactoring.
                                      Open

                                            class HeredocArgumentClosingParenthesis < Base
                                              include RangeHelp
                                              extend AutoCorrector
                                      
                                              MSG = 'Put the closing parenthesis for a method call with a ' \
                                      Severity: Minor
                                      Found in lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb - About 3 hrs to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language