Sign upLogin

bbc/psammead

View on GitHub
Star
packages/utilities/psammead-rich-text-transforms/src/candy-xml.js

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Avoid too many return statements within this function.
Open

  return {
    type: node.name,
    model: {
      text: getTextFromChildBlocks(childBlocks),
      blocks: childBlocks,
Severity: Major
Found in packages/utilities/psammead-rich-text-transforms/src/candy-xml.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return convertToBlocks(node, [...attributes, styleAttribute]);
    Severity: Major
    Found in packages/utilities/psammead-rich-text-transforms/src/candy-xml.js - About 30 mins to fix

      Function xmlNodeToBlock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const xmlNodeToBlock = (node, attributes) => {
  if (!is(Object, node)) return undefined;

  if (node.type === 'text') {
    return fragment(node.text, attributes);
      Severity: Minor
      Found in packages/utilities/psammead-rich-text-transforms/src/candy-xml.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convertToBlocks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const convertToBlocks = (node, attributes = []) =>
  pathOr([], ['children'], node).reduce((acc, childNode) => {
    if (isXmlNodeSupported(childNode, attributes)) {
      return handleSupportedNodes(childNode, attributes, acc);
    }
      Severity: Minor
      Found in packages/utilities/psammead-rich-text-transforms/src/candy-xml.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status