Sign upLogin

bbc/simorgh

View on GitHub
Star
cypress/e2e/pages/onDemandAudio/tests.js

Summary

Maintainability
C
1 day
Test Coverage

Function test has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        it('should be displayed if the toggle is on, and shows the expected number of items', function test() {
          let toggleName;

          if (Cypress.env('currentPath').includes('podcasts')) {
            toggleName = 'recentPodcastEpisodes';
Severity: Major
Found in cypress/e2e/pages/onDemandAudio/tests.js - About 4 hrs to fix

    Function test has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            it('should be displayed if there is enough schedule data', function test() {
          const currentPath = `${Cypress.env(
            'currentPath',
          )}.json${overrideRendererOnTest()}`;
    Severity: Minor
    Found in cypress/e2e/pages/onDemandAudio/tests.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                        if (expectedNumberOfEpisodes > 1) {
                    cy.get('[data-e2e=recent-episodes-list]').should('exist');

                    cy.get('[data-e2e=recent-episodes-list]').within(() => {
                      cy.get('[data-e2e=recent-episodes-list-item]')
      Severity: Major
      Found in cypress/e2e/pages/onDemandAudio/tests.js and 1 other location - About 3 hrs to fix
      cypress/e2e/pages/onDemandTV/tests.js on lines 87..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status