Sign upLogin

bbc/simorgh

View on GitHub
Star
src/app/lib/logger.web.test.js

Summary

Maintainability
D
3 days
Test Coverage

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  it('logger.debug should run console.debug in development', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.debug(event, message);

    expect(global.console.debug).toHaveBeenCalledWith({ event, message });
Severity: Major
Found in src/app/lib/logger.web.test.js and 6 other locations - About 2 hrs to fix
src/app/lib/logger.web.test.js on lines 25..31
src/app/lib/logger.web.test.js on lines 75..81
src/app/lib/logger.web.test.js on lines 83..89
src/app/lib/logger.web.test.js on lines 91..97
src/app/lib/logger.web.test.js on lines 107..113
src/app/lib/logger.web.test.js on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  it('logger.info should run console.info in development', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.info(event, message);

    expect(global.console.info).toHaveBeenCalledWith({ event, message });
Severity: Major
Found in src/app/lib/logger.web.test.js and 6 other locations - About 2 hrs to fix
src/app/lib/logger.web.test.js on lines 25..31
src/app/lib/logger.web.test.js on lines 75..81
src/app/lib/logger.web.test.js on lines 83..89
src/app/lib/logger.web.test.js on lines 99..105
src/app/lib/logger.web.test.js on lines 107..113
src/app/lib/logger.web.test.js on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  it('logger.warn should run console.warn in development', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.warn(event, message);

    expect(global.console.warn).toHaveBeenCalledWith({ event, message });
Severity: Major
Found in src/app/lib/logger.web.test.js and 6 other locations - About 2 hrs to fix
src/app/lib/logger.web.test.js on lines 25..31
src/app/lib/logger.web.test.js on lines 75..81
src/app/lib/logger.web.test.js on lines 91..97
src/app/lib/logger.web.test.js on lines 99..105
src/app/lib/logger.web.test.js on lines 107..113
src/app/lib/logger.web.test.js on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  it('logger.error should run console.error in development', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.error(event, message);

    expect(global.console.error).toHaveBeenCalledWith({ event, message });
Severity: Major
Found in src/app/lib/logger.web.test.js and 6 other locations - About 2 hrs to fix
src/app/lib/logger.web.test.js on lines 25..31
src/app/lib/logger.web.test.js on lines 83..89
src/app/lib/logger.web.test.js on lines 91..97
src/app/lib/logger.web.test.js on lines 99..105
src/app/lib/logger.web.test.js on lines 107..113
src/app/lib/logger.web.test.js on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  it('logger.error should run console.error in production', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.error(event, message);

    expect(global.console.error).toHaveBeenCalledWith({ event, message });
Severity: Major
Found in src/app/lib/logger.web.test.js and 6 other locations - About 2 hrs to fix
src/app/lib/logger.web.test.js on lines 75..81
src/app/lib/logger.web.test.js on lines 83..89
src/app/lib/logger.web.test.js on lines 91..97
src/app/lib/logger.web.test.js on lines 99..105
src/app/lib/logger.web.test.js on lines 107..113
src/app/lib/logger.web.test.js on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  it('logger.verbose should run console.log in development', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.verbose(event, message);

    expect(global.console.log).toHaveBeenCalledWith({ event, message });
Severity: Major
Found in src/app/lib/logger.web.test.js and 6 other locations - About 2 hrs to fix
src/app/lib/logger.web.test.js on lines 25..31
src/app/lib/logger.web.test.js on lines 75..81
src/app/lib/logger.web.test.js on lines 83..89
src/app/lib/logger.web.test.js on lines 91..97
src/app/lib/logger.web.test.js on lines 99..105
src/app/lib/logger.web.test.js on lines 115..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  it('logger.silly should run console.log in development', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.silly(event, message);

    expect(global.console.log).toHaveBeenCalledWith({ event, message });
Severity: Major
Found in src/app/lib/logger.web.test.js and 6 other locations - About 2 hrs to fix
src/app/lib/logger.web.test.js on lines 25..31
src/app/lib/logger.web.test.js on lines 75..81
src/app/lib/logger.web.test.js on lines 83..89
src/app/lib/logger.web.test.js on lines 91..97
src/app/lib/logger.web.test.js on lines 99..105
src/app/lib/logger.web.test.js on lines 107..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('logger.warn should not run console.warn in production', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.warn(message);

    expect(global.console.warn).not.toHaveBeenCalled();
Severity: Major
Found in src/app/lib/logger.web.test.js and 4 other locations - About 1 hr to fix
src/app/lib/logger.web.test.js on lines 40..45
src/app/lib/logger.web.test.js on lines 47..52
src/app/lib/logger.web.test.js on lines 54..59
src/app/lib/logger.web.test.js on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('logger.verbose should not run console.log in production', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.verbose(message);

    expect(global.console.log).not.toHaveBeenCalled();
Severity: Major
Found in src/app/lib/logger.web.test.js and 4 other locations - About 1 hr to fix
src/app/lib/logger.web.test.js on lines 33..38
src/app/lib/logger.web.test.js on lines 40..45
src/app/lib/logger.web.test.js on lines 47..52
src/app/lib/logger.web.test.js on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('logger.silly should not run console.log in production', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.silly(message);

    expect(global.console.log).not.toHaveBeenCalled();
Severity: Major
Found in src/app/lib/logger.web.test.js and 4 other locations - About 1 hr to fix
src/app/lib/logger.web.test.js on lines 33..38
src/app/lib/logger.web.test.js on lines 40..45
src/app/lib/logger.web.test.js on lines 47..52
src/app/lib/logger.web.test.js on lines 54..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('logger.debug should not run console.debug in production', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.debug(message);

    expect(global.console.debug).not.toHaveBeenCalled();
Severity: Major
Found in src/app/lib/logger.web.test.js and 4 other locations - About 1 hr to fix
src/app/lib/logger.web.test.js on lines 33..38
src/app/lib/logger.web.test.js on lines 40..45
src/app/lib/logger.web.test.js on lines 54..59
src/app/lib/logger.web.test.js on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  it('logger.info should not run console.info in production', () => {
    const loggerInstance = loggerWeb('');
    loggerInstance.info(message);

    expect(global.console.info).not.toHaveBeenCalled();
Severity: Major
Found in src/app/lib/logger.web.test.js and 4 other locations - About 1 hr to fix
src/app/lib/logger.web.test.js on lines 33..38
src/app/lib/logger.web.test.js on lines 47..52
src/app/lib/logger.web.test.js on lines 54..59
src/app/lib/logger.web.test.js on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status