bbc/simorgh

File index.test.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import loggerMock from '#testHelpers/loggerMock'; // Must be imported before fetchPageData
import {
  DATA_FETCH_ERROR,
  DATA_REQUEST_RECEIVED,
  DATA_RESPONSE_FROM_CACHE,

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it('should log, and return the status code as 502', async () => {
      fetch.mockResponse("I'm a teapot", { status: 418 });

      return fetchPageData({ path: requestedPathname, pageType }).catch(
        ({ message, status }) => {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it('should log, and propogate the status code as 502', async () => {
      fetch.mockResponse('Internal server error', { status: 500 });
      return fetchPageData({ path: requestedPathname, pageType }).catch(
        ({ message, status }) => {
          expect(loggerMock.error).toBeCalledWith(DATA_FETCH_ERROR, {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      it('should log, and propogate the status code as 500', async () => {
        fetch.mockResponse('Error', { status: 500 });

        return fetchPageData({ path: requestedPathname, pageType }).catch(
          ({ message, status }) => {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('on server', () => {
      it('should return a 500 error code', () => {
        setWindowValue('location', false);

        return fetchPageData({ path: requestedPathname, pageType }).catch(

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('on client', () => {
      it('should return a 502 error code', () => {
        setWindowValue('location', true);

        return fetchPageData({ path: requestedPathname, pageType }).catch(

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    beforeEach(() => {
      fetch.mockResponse(
        JSON.stringify({
          metadata: {},
          content: {},

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    beforeEach(() => {
      fetch.mockResponse(
        JSON.stringify({
          metadata: {},
          content: {},

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch on amp pages without .amp in pathname', async () => {
      await fetchPageData({ path: requestedPathname, pageType });

      expect(fetch).toHaveBeenCalledWith(expectedUrl, fetchOptions);
    });

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch with the correct url when passed the pathname', async () => {
      await fetchPageData({ path: requestedPathname, pageType });

      expect(fetch).toHaveBeenCalledWith(expectedUrl, fetchOptions);
    });

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch with the correct url when passed the full test path', async () => {
      await fetchPageData({ path: fullTestPath, pageType });

      expect(fetch).toHaveBeenCalledWith(fullTestPath, fetchOptions);
    });

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch with the correct url when passed the full live path', async () => {
      await fetchPageData({ path: fullLivePath, pageType });

      expect(fetch).toHaveBeenCalledWith(fullLivePath, fetchOptions);
    });

• Read up
  Read up