bbc/sqs-producer

View on GitHub

Showing 3 of 5 total issues

Function entryFromObject has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

function entryFromObject(message: Message): SendMessageBatchRequestEntry {
  if (!message.body) {
    throw new Error(`Object messages must have 'body' prop`);
  }

Severity: Minor
Found in src/format.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function entryFromObject has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function entryFromObject(message: Message): SendMessageBatchRequestEntry {
  if (!message.body) {
    throw new Error(`Object messages must have 'body' prop`);
  }

Severity: Minor
Found in src/format.ts - About 2 hrs to fix

    Function sendBatch has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private async sendBatch(
        failedMessages?: string[],
        successfulMessages?: SendMessageBatchResultEntry[],
        messages?: (string | Message)[],
        startIndex?: number
    Severity: Minor
    Found in src/producer.ts - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language