bbc/unicode-bidirectional

View on GitHub

Showing 27 of 46 total issues

Function isolatingRunSequences has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function isolatingRunSequences(paragraphCodepoints, paragraphBidiTypes, paragraphLevel = 0) {
  // [1]: By X9., we remove control characters that are not
  //      needed at this stage in bidi algorithm
  const { runs, bidiTypes, levels } = levelRuns(paragraphCodepoints, paragraphBidiTypes, paragraphLevel);

Severity: Major
Found in src/paragraph/isolatingRunSequences.js - About 2 hrs to fix

    Function resolveBrackets has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function resolveBrackets(bidiTypes, points, sos, eos, level, bidiTypesBeforeW1) {
      // [1]: If any strong type (either L or R) matching the embedding direction
      //      is found, set the type for both brackets in the pair to
      //      match the embedding direction.
      const pairs = bracketPairs(points);
    Severity: Major
    Found in src/neutral/resolveBrackets.js - About 2 hrs to fix

      Function bracketPairs has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      function bracketPairs(points, bidiTypes) {
        // [1]: Sort the list of pairs of text positions in ascending order
        //      based on the text position of the opening paired bracket.
        // [*]: "If an opening paired bracket is found and there is no room in the stack,
        //       stop processing BD16 for the remainder of the isolating run sequence."
      Severity: Minor
      Found in src/neutral/bracketPairs.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resolvedWeaksForSequence has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function resolvedWeaksForSequence(codepoints, bidiTypes, sequence) {
        // merge together all the codepoint-slices and bidiType-slices
        // that each run in the sequence take
        const paragraph = codepoints.zip(bidiTypes);
        const [ codepointsFromSequence, bidiTypesFromSequence ] = unzip(
      Severity: Minor
      Found in src/weak/resolvedWeaks.js - About 1 hr to fix

        Function levelRuns has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function levelRuns(codepoints, bidiTypes, paragraphLevel = 0) {
          const rules = [
            rle,   // X2.
            lre,   // X3.
            rlo,   // X4.
        Severity: Minor
        Found in src/paragraph/levelRuns.js - About 1 hr to fix

          Function matchingPDIForIndex has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function matchingPDIForIndex(codepoints, index) {
            if (index >= codepoints.size) { return -1; }
            if (!includes([LRI, RLI, FSI], codepoints.get(index))) { return -1; }
          
            const after = codepoints.slice(index + 1);
          Severity: Minor
          Found in src/paragraph/matchingPDIForIndex.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function pdi has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function pdi(ch, bidiType, index, state) {
            if (ch !== PDI) return state;
            const isolateOverflow = state.get('overflowIsolateCount');
            const validIsolateCount = state.get('validIsolateCount');
          
          
          Severity: Minor
          Found in src/paragraph/rule/pdi.js - About 1 hr to fix

            Function bracketPairs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function bracketPairs(points, bidiTypes) {
              // [1]: Sort the list of pairs of text positions in ascending order
              //      based on the text position of the opening paired bracket.
              // [*]: "If an opening paired bracket is found and there is no room in the stack,
              //       stop processing BD16 for the remainder of the isolating run sequence."
            Severity: Minor
            Found in src/neutral/bracketPairs.js - About 1 hr to fix

              Function pdi has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              function pdi(ch, bidiType, index, state) {
                if (ch !== PDI) return state;
                const isolateOverflow = state.get('overflowIsolateCount');
                const validIsolateCount = state.get('validIsolateCount');
              
              
              Severity: Minor
              Found in src/paragraph/rule/pdi.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function lri has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function lri(ch, bidiType, index, state) {
                if (ch !== LRI) return state;
                const lastEntry = state.get('directionalStatusStack').peek();
                const lastLevel = lastEntry.get('level');
              
              
              Severity: Minor
              Found in src/paragraph/rule/lri.js - About 1 hr to fix

                Function rli has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function rli(ch, bidiType, index, state) {
                  if (ch !== RLI) return state;
                  const lastEntry = state.get('directionalStatusStack').peek();
                  const lastLevel = lastEntry.get('level');
                
                
                Severity: Minor
                Found in src/paragraph/rule/rli.js - About 1 hr to fix

                  Function rli has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function rli(ch, bidiType, index, state) {
                    if (ch !== RLI) return state;
                    const lastEntry = state.get('directionalStatusStack').peek();
                    const lastLevel = lastEntry.get('level');
                  
                  
                  Severity: Minor
                  Found in src/paragraph/rule/rli.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function lri has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function lri(ch, bidiType, index, state) {
                    if (ch !== LRI) return state;
                    const lastEntry = state.get('directionalStatusStack').peek();
                    const lastLevel = lastEntry.get('level');
                  
                  
                  Severity: Minor
                  Found in src/paragraph/rule/lri.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function finalState has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    const finalState = points.reduce((state, point, position) => {
                      if (state.get('stackoverflow') === true) return state; // [*]
                  
                      const stack = state.get('stack');
                  
                  
                  Severity: Minor
                  Found in src/neutral/bracketPairs.js - About 1 hr to fix

                    Function rlo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function rlo(ch, bidiType, index, state) {
                      if (ch !== RLO) return state;
                    
                      const lastLevel = state.get('directionalStatusStack').peek().get('level');
                      const isolate = state.get('overflowIsolateCount');
                    Severity: Minor
                    Found in src/paragraph/rule/rlo.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function lro has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function lro(ch, bidiType, index, state) {
                      if (ch !== LRO) return state;
                    
                      const lastLevel = state.get('directionalStatusStack').peek().get('level');
                      const isolate = state.get('overflowIsolateCount');
                    Severity: Minor
                    Found in src/paragraph/rule/lro.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function fsi has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function fsi(codepoint, bidiType, index, state, codepoints, bidiTypes) {
                    Severity: Minor
                    Found in src/paragraph/rule/fsi.js - About 45 mins to fix

                      Function resolveBrackets has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function resolveBrackets(bidiTypes, points, sos, eos, level, bidiTypesBeforeW1) {
                      Severity: Minor
                      Found in src/neutral/resolveBrackets.js - About 45 mins to fix

                        Function resolveRemaining has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function resolveRemaining(types, codepoints, sos, eos, level) {
                        Severity: Minor
                        Found in src/neutral/resolveRemaining.js - About 35 mins to fix

                          Function enToL has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          function enToL(types, points, sos, eos, level) {
                          Severity: Minor
                          Found in src/weak/rule/enToL.js - About 35 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language