bbc/unicode-bidirectional

View on GitHub
src/neutral/bracketPairs.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function bracketPairs has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function bracketPairs(points, bidiTypes) {
  // [1]: Sort the list of pairs of text positions in ascending order
  //      based on the text position of the opening paired bracket.
  // [*]: "If an opening paired bracket is found and there is no room in the stack,
  //       stop processing BD16 for the remainder of the isolating run sequence."
Severity: Minor
Found in src/neutral/bracketPairs.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bracketPairs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function bracketPairs(points, bidiTypes) {
  // [1]: Sort the list of pairs of text positions in ascending order
  //      based on the text position of the opening paired bracket.
  // [*]: "If an opening paired bracket is found and there is no room in the stack,
  //       stop processing BD16 for the remainder of the isolating run sequence."
Severity: Minor
Found in src/neutral/bracketPairs.js - About 1 hr to fix

    Function finalState has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const finalState = points.reduce((state, point, position) => {
        if (state.get('stackoverflow') === true) return state; // [*]
    
        const stack = state.get('stack');
    
    
    Severity: Minor
    Found in src/neutral/bracketPairs.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return state;
      Severity: Major
      Found in src/neutral/bracketPairs.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return state;
        Severity: Major
        Found in src/neutral/bracketPairs.js - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status