Sign upLogin

bborn/communityengine

View on GitHub
Star
app/assets/javascripts/jcrop/jquery.color.js

Summary

Maintainability
D
2 days
Test Coverage

File jquery.color.js has 553 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery Color Animations v2.0pre
 * http://jquery.org/
 *
 * Copyright 2011 John Resig
Severity: Major
Found in app/assets/javascripts/jcrop/jquery.color.js - About 1 day to fix

    Function parse has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            parse: function( red, green, blue, alpha ) {
            if ( red === undefined ) {
                this._rgba = [ null, null, null, null ];
                return this;
            }
    Severity: Minor
    Found in app/assets/javascripts/jcrop/jquery.color.js - About 1 hr to fix

      Function to has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          spaces.hsla.to = function ( rgba ) {
        if ( rgba[ 0 ] == null || rgba[ 1 ] == null || rgba[ 2 ] == null ) {
            return [ null, null, null, rgba[ 3 ] ];
        }
        var r = rgba[ 0 ] / 255,
      Severity: Minor
      Found in app/assets/javascripts/jcrop/jquery.color.js - About 1 hr to fix

        Function transition has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                transition: function( other, distance ) {
            var end = color( other ),
                spaceName = end._space(),
                space = spaces[ spaceName ],
                start = this[ space.cache ] || space.to( this._rgba ),
        Severity: Minor
        Found in app/assets/javascripts/jcrop/jquery.color.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                              if ( !support.rgba && value._rgba[ 3 ] !== 1 ) {
                        curElem = hook === "backgroundColor" ? elem.parentNode : elem;
                        do {
                            backgroundColor = jQuery.curCSS( curElem, "backgroundColor" );
                        } while (
          Severity: Major
          Found in app/assets/javascripts/jcrop/jquery.color.js - About 40 mins to fix

            Avoid too many return statements within this function.
            Open

                    return type.min > value ? type.min : type.max < value ? type.max : value;
            Severity: Major
            Found in app/assets/javascripts/jcrop/jquery.color.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( rgba[ 0 ] == null || rgba[ 1 ] == null || rgba[ 2 ] == null ) {
            return [ null, null, null, rgba[ 3 ] ];
        }
              Severity: Minor
              Found in app/assets/javascripts/jcrop/jquery.color.js and 1 other location - About 50 mins to fix
              app/assets/javascripts/jcrop/jquery.color.js on lines 468..470

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( hsla[ 0 ] == null || hsla[ 1 ] == null || hsla[ 2 ] == null ) {
            return [ null, null, null, hsla[ 3 ] ];
        }
              Severity: Minor
              Found in app/assets/javascripts/jcrop/jquery.color.js and 1 other location - About 50 mins to fix
              app/assets/javascripts/jcrop/jquery.color.js on lines 433..435

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status