Sign upLogin

bbozo/simple_form_class

View on GitHub
Star

Showing 5 of 5 total issues

Class Base has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Base

    MANDATORY_OWNER_METHODS = [ :attributes, :attributes=, :valid?, :save ]

    extend ActiveModel::Callbacks
Severity: Minor
Found in lib/simple_form_class/base.rb - About 2 hrs to fix

    Method new has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.new(*args)
      Class.new(HashWithIndifferentAccess) do
        cattr_accessor :accessorized_keys

        self.accessorized_keys = args.map(&:to_s)
    Severity: Minor
    Found in lib/simple_form_class/mock.rb - About 1 hr to fix

      Method save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def save(*args)
      local_options = args.last.is_a?(Hash) ? args.last : {}
      validate = local_options.has_key?(:validate) ? local_options[:validate] : true

      if validate
      Severity: Minor
      Found in lib/simple_form_class/base.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method attributes= has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def attributes=(attributes)
      self.class.owners.each do |owner|
        owners_hash = attributes_for_owner owner, attributes
        owners_attribute_setter = owner == :self ? :private_attributes= : :attributes=
      Severity: Minor
      Found in lib/simple_form_class/base.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method delegate_validators_from_owners has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def delegate_validators_from_owners
      self.class.owners.each do |owner_sym|
        next if owner_sym == :self

        owner = send owner_sym
      Severity: Minor
      Found in lib/simple_form_class/base.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language