bcdice/BCDice

View on GitHub

Showing 829 of 1,274 total issues

Method getStepResult has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

      def getStepResult(str)
        return nil unless /(\d+)E(\d+)?(\+)?(\d+)?(d\d+)?/i =~ str

        stepTotal = 0
        @isFailed = true
Severity: Minor
Found in lib/bcdice/game_system/EarthDawn.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File FilledWith.rb has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class FilledWith < Base
      # ゲームシステムの識別子
      ID = 'FilledWith'
Severity: Minor
Found in lib/bcdice/game_system/FilledWith.rb - About 3 hrs to fix

    Method resolute_action has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

          def resolute_action(command)
            m = /^(\d*)([+\d]+)*FF<=(\d)(,(\d))?(&(\d))?$/.match(command)
            return nil unless m
    
            heat_level = m[1].to_i
    Severity: Minor
    Found in lib/bcdice/game_system/FullFace.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File LiveraDoll.rb has 293 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module BCDice
      module GameSystem
        class LiveraDoll < Base
          # ゲームシステムの識別子
          ID = 'LiveraDoll'
    Severity: Minor
    Found in lib/bcdice/game_system/LiveraDoll.rb - About 3 hrs to fix

      File BeastBindTrinity.rb has 293 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'bcdice/arithmetic_evaluator'
      require 'bcdice/format'
      require 'bcdice/normalize'
      require 'bcdice/dice_table/table'
      require 'bcdice/dice_table/d66_grid_table'
      Severity: Minor
      Found in lib/bcdice/game_system/BeastBindTrinity.rb - About 3 hrs to fix

        File Warhammer.rb has 292 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module BCDice
          module GameSystem
            class Warhammer < Base
              # ゲームシステムの識別子
              ID = 'Warhammer'
        Severity: Minor
        Found in lib/bcdice/game_system/Warhammer.rb - About 3 hrs to fix

          Method getFumbleTypeAndTable has 75 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def getFumbleTypeAndTable(head)
                  case head
                  when "S"
                    type = '射撃'
                    # 射撃ファンブル表
          Severity: Major
          Found in lib/bcdice/game_system/GundogRevised.rb - About 3 hrs to fix

            Method getFumbleTypeAndTable has 75 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def getFumbleTypeAndTable(head)
                    case head
                    when "S"
                      type = '射撃'
                      # 射撃ファンブル表
            Severity: Major
            Found in lib/bcdice/game_system/GundogZero.rb - About 3 hrs to fix

              File Torg.rb has 291 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              module BCDice
                module GameSystem
                  class Torg < Base
                    # ゲームシステムの識別子
                    ID = 'Torg'
              Severity: Minor
              Found in lib/bcdice/game_system/Torg.rb - About 3 hrs to fix

                File Satasupe.rb has 291 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require "bcdice/game_system/satasupe/tables"
                
                module BCDice
                  module GameSystem
                    class Satasupe < Base
                Severity: Minor
                Found in lib/bcdice/game_system/Satasupe.rb - About 3 hrs to fix

                  File TheOneRing2nd.rb has 289 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  module BCDice
                    module GameSystem
                      class TheOneRing2nd < Base
                        # ゲームシステムの識別子
                        ID = "TheOneRing2nd"
                  Severity: Minor
                  Found in lib/bcdice/game_system/TheOneRing2nd.rb - About 2 hrs to fix

                    Method roll_amadeus has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def roll_amadeus(command)
                            m = /^R([A-DS])([+\-\d]*)(@(\d))?((>=?)([+\-\d]*))?(@(\d))?$/i.match(command)
                            unless m
                              return nil
                            end
                    Severity: Minor
                    Found in lib/bcdice/game_system/Amadeus.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method attack_roll has 70 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          def attack_roll(command)
                            m = /^AT([-+]\d+)?(@(\d+))?(>=(\d+))?([AD]?)/.match(command)
                            unless m
                              return nil
                            end
                    Severity: Major
                    Found in lib/bcdice/game_system/DungeonsAndDragons5.rb - About 2 hrs to fix

                      Method checkRoll has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def checkRoll(rapid, target, damage, isCritical, criticalNumber)
                              totalSuccessCount = 0
                              totalCriticalCount = 0
                              text = ""
                      
                      
                      Severity: Minor
                      Found in lib/bcdice/game_system/Alsetto.rb - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method initiative_roll has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def initiative_roll(command)
                              m = /^(\d+\.?\d*)?(INTI|inti)([+-](\d+))?(#(\d+))?/.match(command)
                              unless m
                                return nil
                              end
                      Severity: Minor
                      Found in lib/bcdice/game_system/TheUnofficialHollowKnightRPG.rb - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method eval_game_system_specific_command has 68 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                            def eval_game_system_specific_command(string)
                              unless parse_ars(string) || parse_1r10(string)
                                return nil
                              end
                      
                      
                      Severity: Major
                      Found in lib/bcdice/game_system/ArsMagica.rb - About 2 hrs to fix

                        Method mh_crc_table has 68 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              def mh_crc_table(suv, num)
                                header_parts = ['戦闘結果チャート', num]
                                separator = ' > '
                        
                                suv = suv.to_s.upcase
                        Severity: Major
                        Found in lib/bcdice/game_system/MetalHead.rb - About 2 hrs to fix

                          Method rating has 68 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                def rating(string) # レーティング表
                                  debug("rating string", string)
                                  command = rating_parser.parse(string)
                          
                                  unless command
                          Severity: Major
                          Found in lib/bcdice/game_system/SwordWorld.rb - About 2 hrs to fix

                            File FutariSousa.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            module BCDice
                              module GameSystem
                                class FutariSousa < Base
                                  # ゲームシステムの識別子
                                  ID = 'FutariSousa'
                            Severity: Minor
                            Found in lib/bcdice/game_system/FutariSousa.rb - About 2 hrs to fix

                              File Cthulhu7th_ChineseTraditional.rb has 279 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              module BCDice
                                module GameSystem
                                  class Cthulhu7th_ChineseTraditional < Base
                                    # ゲームシステムの識別子
                                    ID = 'Cthulhu7th:ChineseTraditional'
                              Severity: Minor
                              Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 2 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language