bcdice/BCDice

View on GitHub

Showing 367 of 1,233 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        d4  = [1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,]
Severity: Major
Found in lib/bcdice/game_system/EarthDawn.rb and 6 other locations - About 1 hr to fix
lib/bcdice/game_system/EarthDawn.rb on lines 157..157
lib/bcdice/game_system/EarthDawn.rb on lines 158..158
lib/bcdice/game_system/EarthDawn.rb on lines 159..159
lib/bcdice/game_system/EarthDawn.rb on lines 160..160
lib/bcdice/game_system/EarthDawn.rb on lines 161..161
lib/bcdice/game_system/EarthDawn.rb on lines 162..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def roll_dt(command, count)
        dice_list = @randomizer.roll_barabara(count, 10)
        max = dice_list.max

        result =
Severity: Major
Found in lib/bcdice/game_system/FutariSousa.rb and 1 other location - About 1 hr to fix
lib/bcdice/game_system/FutariSousa.rb on lines 110..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def roll_as(command, count)
        dice_list = @randomizer.roll_barabara(count, 6)
        max = dice_list.max

        result =
Severity: Major
Found in lib/bcdice/game_system/FutariSousa.rb and 1 other location - About 1 hr to fix
lib/bcdice/game_system/FutariSousa.rb on lines 90..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

          when 2
            table = [
              "財宝(カギ・トラップなし)。財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギつき。行動を消費して#{getRandomDiff(dice1, 22, d, 0)}に成功すれば開く)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギなし、トラップつき。行動を消費して#{getRandomDiff(dice1, 23, d, 0)}に成功すれば解除可能)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
Severity: Major
Found in lib/bcdice/game_system/GurpsFW.rb and 5 other locations - About 1 hr to fix
lib/bcdice/game_system/GurpsFW.rb on lines 1010..1018
lib/bcdice/game_system/GurpsFW.rb on lines 1085..1093
lib/bcdice/game_system/GurpsFW.rb on lines 1165..1173
lib/bcdice/game_system/GurpsFW.rb on lines 1232..1240
lib/bcdice/game_system/GurpsFW.rb on lines 1369..1377

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

          when 2
            table = [
              "財宝(カギ・トラップなし)。財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギつき。行動を消費して#{getRandomDiff(dice1, 22, d, 0)}に成功すれば開く)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギなし、トラップつき。行動を消費して#{getRandomDiff(dice1, 23, d, 0)}に成功すれば解除可能)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
Severity: Major
Found in lib/bcdice/game_system/GurpsFW.rb and 5 other locations - About 1 hr to fix
lib/bcdice/game_system/GurpsFW.rb on lines 1010..1018
lib/bcdice/game_system/GurpsFW.rb on lines 1165..1173
lib/bcdice/game_system/GurpsFW.rb on lines 1232..1240
lib/bcdice/game_system/GurpsFW.rb on lines 1299..1307
lib/bcdice/game_system/GurpsFW.rb on lines 1369..1377

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

          when 2
            table = [
              "財宝(カギ・トラップなし)。財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギつき。行動を消費して#{getRandomDiff(dice1, 22, d, 0)}に成功すれば開く)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギなし、トラップつき。行動を消費して#{getRandomDiff(dice1, 23, d, 0)}に成功すれば解除可能)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
Severity: Major
Found in lib/bcdice/game_system/GurpsFW.rb and 5 other locations - About 1 hr to fix
lib/bcdice/game_system/GurpsFW.rb on lines 1010..1018
lib/bcdice/game_system/GurpsFW.rb on lines 1085..1093
lib/bcdice/game_system/GurpsFW.rb on lines 1165..1173
lib/bcdice/game_system/GurpsFW.rb on lines 1299..1307
lib/bcdice/game_system/GurpsFW.rb on lines 1369..1377

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

          when 2
            table = [
              "財宝(カギ・トラップなし)。財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギつき。行動を消費して#{getRandomDiff(dice1, 22, d, 0)}に成功すれば開く)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギなし、トラップつき。行動を消費して#{getRandomDiff(dice1, 23, d, 0)}に成功すれば解除可能)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
Severity: Major
Found in lib/bcdice/game_system/GurpsFW.rb and 5 other locations - About 1 hr to fix
lib/bcdice/game_system/GurpsFW.rb on lines 1010..1018
lib/bcdice/game_system/GurpsFW.rb on lines 1085..1093
lib/bcdice/game_system/GurpsFW.rb on lines 1165..1173
lib/bcdice/game_system/GurpsFW.rb on lines 1232..1240
lib/bcdice/game_system/GurpsFW.rb on lines 1299..1307

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

          when 2
            table = [
              "財宝(カギ・トラップなし)。財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギつき。行動を消費して#{getRandomDiff(dice1, 22, d, 0)}に成功すれば開く)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギなし、トラップつき。行動を消費して#{getRandomDiff(dice1, 23, d, 0)}に成功すれば解除可能)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
Severity: Major
Found in lib/bcdice/game_system/GurpsFW.rb and 5 other locations - About 1 hr to fix
lib/bcdice/game_system/GurpsFW.rb on lines 1010..1018
lib/bcdice/game_system/GurpsFW.rb on lines 1085..1093
lib/bcdice/game_system/GurpsFW.rb on lines 1232..1240
lib/bcdice/game_system/GurpsFW.rb on lines 1299..1307
lib/bcdice/game_system/GurpsFW.rb on lines 1369..1377

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

          when 2
            table = [
              "財宝(カギ・トラップなし)。財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギつき。行動を消費して#{getRandomDiff(dice1, 22, d, 0)}に成功すれば開く)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
              "財宝(カギなし、トラップつき。行動を消費して#{getRandomDiff(dice1, 23, d, 0)}に成功すれば解除可能)財宝の中身は1段階低い深度の財宝テーブルを使用する。",
Severity: Major
Found in lib/bcdice/game_system/GurpsFW.rb and 5 other locations - About 1 hr to fix
lib/bcdice/game_system/GurpsFW.rb on lines 1085..1093
lib/bcdice/game_system/GurpsFW.rb on lines 1165..1173
lib/bcdice/game_system/GurpsFW.rb on lines 1232..1240
lib/bcdice/game_system/GurpsFW.rb on lines 1299..1307
lib/bcdice/game_system/GurpsFW.rb on lines 1369..1377

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      REST_ITEM_TABLE = DiceTable::D66Table.new(
        "回復アイテム表",
        D66SortType::ASC,
        {
          11 => "チョコレート(お弁当)",
Severity: Major
Found in lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      WEAPON_ITEM_TABLE = DiceTable::D66Table.new(
        "武具アイテム表",
        D66SortType::ASC,
        {
          11 => "だんびら",
Severity: Major
Found in lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      ConvenienceItemTable = DiceTable::D66Table.new(
        '便利系アイテム表',
        D66SortType::ASC,
        {
          11 => 'ちくわ',
Severity: Major
Found in lib/bcdice/game_system/ShuumatsuBargainWars.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      SEARCH_ITEM_TABLE = DiceTable::D66Table.new(
        "探索アイテム表",
        D66SortType::ASC,
        {
          11 => "拷問具(星の欠片)",
Severity: Major
Found in lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      NICKNAME_TABLE4 = DiceTable::D66Table.new(
        '二つ名表4',
        D66SortType::ASC,
        {
          11 => '「国産」',
Severity: Major
Found in lib/bcdice/game_system/YankeeYogSothoth.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def eval_game_system_specific_command(command)
        case command
        when %r{(AK|AKG)(-?\d+)(/(\d+))?(@(\d+))?}i
          success_rate = Regexp.last_match(2).to_i
          repeat_count = (Regexp.last_match(4) || 1).to_i
Severity: Major
Found in lib/bcdice/game_system/AceKillerGene.rb and 1 other location - About 1 hr to fix
lib/bcdice/game_system/GardenOrder.rb on lines 33..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      LIFE_ITEM_TABLE = DiceTable::D66Table.new(
        "生活アイテム表",
        D66SortType::ASC,
        {
          11 => "鍋",
Severity: Major
Found in lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      WeaponItemTable = DiceTable::D66Table.new(
        '武器系アイテム表',
        D66SortType::ASC,
        {
          11 => 'アズキアイス',
Severity: Major
Found in lib/bcdice/game_system/ShuumatsuBargainWars.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      NICKNAME_TABLE1 = DiceTable::D66Table.new(
        '二つ名表1',
        D66SortType::ASC,
        {
          11 => '「愛死天流(あいしてる)」',
Severity: Major
Found in lib/bcdice/game_system/YankeeYogSothoth.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      NICKNAME_TABLE3 = DiceTable::D66Table.new(
        '二つ名表3',
        D66SortType::ASC,
        {
          11 => '「ファッションヤンキー」',
Severity: Major
Found in lib/bcdice/game_system/YankeeYogSothoth.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 33..57
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

      RecoveryItemTable = DiceTable::D66Table.new(
        '回復系アイテム表',
        D66SortType::ASC,
        {
          11 => '飴玉',
Severity: Major
Found in lib/bcdice/game_system/ShuumatsuBargainWars.rb and 10 other locations - About 1 hr to fix
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 61..85
lib/bcdice/game_system/ShuumatsuBargainWars.rb on lines 89..113
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 66..90
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 94..118
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 122..146
lib/bcdice/game_system/YankeeYogSothoth.rb on lines 150..174
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 6..30
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 34..58
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 62..86
lib/bcdice/game_system/meikyu_kingdom_basic/item_table.rb on lines 90..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language