bcgov/document-generation-showcase

View on GitHub

Showing 9 of 140 total issues

Function init has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function init(config, watch, options) {
  const ctor = sanitizeConfig(config);
  const keycloak = new Keycloak(ctor);

  watch.$once('ready', function (cb) {
Severity: Major
Found in app/frontend/src/plugins/keycloak.js - About 2 hrs to fix

    Function install has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      install: function (Vue, params = {}) {
        if (installed) return;
        installed = true;
    
        const defaultParams = {
    Severity: Major
    Found in app/frontend/src/plugins/keycloak.js - About 2 hrs to fix

      Function authenticate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        authenticate: (req, res, next) => {
      
          const authorization = req.get('Authorization');
          if (!authorization || !authorization.startsWith('Bearer ')) {
            return new Problem(401, {
      Severity: Minor
      Found in app/src/middleware/authentication.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function authenticate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        authenticate: (req, res, next) => {
      
          const authorization = req.get('Authorization');
          if (!authorization || !authorization.startsWith('Bearer ')) {
            return new Problem(401, {
      Severity: Minor
      Found in app/src/middleware/authentication.js - About 1 hr to fix

        Function data has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              data() {
                return {
                  ready: false,
                  authenticated: false,
                  userName: null,
        Severity: Minor
        Found in app/frontend/src/plugins/keycloak.js - About 1 hr to fix

          Function constructor has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor({ tokenUrl, clientId, clientSecret }) {
              log.verbose(
                'ClientConnection',
                `Constructed with ${tokenUrl}, ${clientId}, clientSecret`
              );
          Severity: Minor
          Found in app/src/cdogsService/clientConnection.js - About 1 hr to fix

            Function updateWatchVariables has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function updateWatchVariables(isAuthenticated = false) {
                watch.authenticated = isAuthenticated;
                watch.loginFn = keycloak.login;
                watch.login = keycloak.login;
                watch.createLoginUrl = keycloak.createLoginUrl;
            Severity: Minor
            Found in app/frontend/src/plugins/keycloak.js - About 1 hr to fix

              Function assertOptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function assertOptions(options) {
                const { config, init, onReady, onInitError } = options;
                if (typeof config !== 'string' && !_isObject(config)) {
                  return { hasError: true, error: `'config' option must be a string or an object. Found: '${config}'` };
                }
              Severity: Minor
              Found in app/frontend/src/plugins/keycloak.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                return {
                  hasError: false,
                  error: null
                };
              Severity: Major
              Found in app/frontend/src/plugins/keycloak.js - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language