Sign upLogin

bcgov/nr-get-token

View on GitHub
Star
app/frontend/src/store/modules/user.js

Summary

Maintainability
B
6 hrs
Test Coverage
F
33%

Consider simplifying this complex logical expression.
Open

      if (Array.isArray(userClients) && userClients.length) {
        state.acronyms = state.acronyms.map(acr => {
          const clientSet = userClients.find(client => client.acronym === acr.acronym);
          acr.clientStatus = {
            dev: clientSet && clientSet.dev && clientSet.dev.enabled,
Severity: Critical
Found in app/frontend/src/store/modules/user.js - About 1 hr to fix

    TODO found
    Open

            // TODO: Create top-level global state error message
    Severity: Minor
    Found in app/frontend/src/store/modules/user.js by fixme

    TODO found
    Open

            // TODO: Create top-level global state error message
    Severity: Minor
    Found in app/frontend/src/store/modules/user.js by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async getAcronymClientStatus(context) {
      try {
        const subject = context.rootGetters['auth/keycloakSubject'];
        const response = await UserService.getServiceClients(subject);
        context.commit('setAcronymClientStatus', response.data);
    Severity: Major
    Found in app/frontend/src/store/modules/user.js and 1 other location - About 2 hrs to fix
    app/frontend/src/store/modules/user.js on lines 65..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async getUserAcronyms(context) {
      try {
        const subject = context.rootGetters['auth/keycloakSubject'];
        const response = await UserService.getUserAcronyms(subject);
        context.commit('setAcronyms', response.data);
    Severity: Major
    Found in app/frontend/src/store/modules/user.js and 1 other location - About 2 hrs to fix
    app/frontend/src/store/modules/user.js on lines 50..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
    Open

    import UserService from '@/services/userService';
    Severity: Minor
    Found in app/frontend/src/store/modules/user.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status