bcgov/nr-get-token

View on GitHub

Showing 12 of 143 total issues

Function createClient has 114 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  async createClient(clientId, name, description) {
    if (!clientId || !name || !description) {
      log.error('A parameter is null.', { function: 'createClient' });
      throw new Error(
        'Cannot create client: clientId, name, and description cannot be null.'
Severity: Major
Found in app/src/components/realmAdminSvc.js - About 3 hrs to fix

    Function manage has 107 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

      async manage({
        applicationAcronym,
        applicationName,
        applicationDescription,
        commonServices,
    Severity: Major
    Found in app/src/components/keyCloakServiceClientMgr.js - About 3 hrs to fix

      Function init has 60 lines of code (exceeds 40 allowed). Consider refactoring.
      Open

      function init(config, watch, options) {
        const ctor = sanitizeConfig(config);
        const keycloak = Keycloak(ctor);
      
        watch.$once('ready', function (cb) {
      Severity: Major
      Found in app/frontend/src/plugins/keycloak.js - About 1 hr to fix

        Function install has 55 lines of code (exceeds 40 allowed). Consider refactoring.
        Open

          install: function (Vue, params = {}) {
            if (installed) return;
            installed = true;
        
            const defaultParams = {
        Severity: Major
        Found in app/frontend/src/plugins/keycloak.js - About 1 hr to fix

          Function manage has a Cognitive Complexity of 14 (exceeds 6 allowed). Consider refactoring.
          Open

            async manage({
              applicationAcronym,
              applicationName,
              applicationDescription,
              commonServices,
          Severity: Minor
          Found in app/src/components/keyCloakServiceClientMgr.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getUsers has 52 lines of code (exceeds 40 allowed). Consider refactoring.
          Open

            getUsers: async (applicationAcronym) => {
              if (!applicationAcronym) {
                const errMsg = 'No app acronym supplied to getUsers';
                log.error(errMsg, { function: 'getUsers' });
                throw new Error(errMsg);
          Severity: Major
          Found in app/src/components/acronyms.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                  if (Array.isArray(userClients) && userClients.length) {
                    state.acronyms = state.acronyms.map(acr => {
                      const clientSet = userClients.find(client => client.acronym === acr.acronym);
                      acr.clientStatus = {
                        dev: clientSet && clientSet.dev && clientSet.dev.enabled,
            Severity: Critical
            Found in app/frontend/src/store/modules/user.js - About 1 hr to fix

              Function exports has 48 lines of code (exceeds 40 allowed). Consider refactoring.
              Open

              module.exports = (sequelize, DataTypes) => {
                const Acronym = sequelize.define('Acronym', {
                  acronymId: {
                    allowNull: false,
                    defaultValue: DataTypes.UUIDV4,
              Severity: Minor
              Found in app/src/models/acronym.js - About 1 hr to fix

                Function exports has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                Open

                module.exports = (sequelize, DataTypes) => {
                  const User = sequelize.define('User', {
                    userId: {
                      allowNull: false,
                      defaultValue: DataTypes.UUIDV4,
                Severity: Minor
                Found in app/src/models/user.js - About 1 hr to fix

                  Avoid too many return statements within this function.
                  Open

                    return {
                      hasError: false,
                      error: null
                    };
                  Severity: Major
                  Found in app/frontend/src/plugins/keycloak.js - About 30 mins to fix

                    Function makeClientDetails has a Cognitive Complexity of 7 (exceeds 6 allowed). Consider refactoring.
                    Open

                      async makeClientDetails(serviceClient) {
                        if (serviceClient && serviceClient.id) {
                          // get the service account user.
                          const serviceAccountUser = await this.svc.getServiceAccountUser(
                            serviceClient.id
                    Severity: Minor
                    Found in app/src/components/keyCloakServiceClientMgr.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function assertOptions has a Cognitive Complexity of 7 (exceeds 6 allowed). Consider refactoring.
                    Open

                    function assertOptions(options) {
                      const { config, init, onReady, onInitError } = options;
                      if (typeof config !== 'string' && !_isObject(config)) {
                        return { hasError: true, error: `'config' option must be a string or an object. Found: '${config}'` };
                      }
                    Severity: Minor
                    Found in app/frontend/src/plugins/keycloak.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language