Sign upLogin

bcongdon/WunderSchedule

View on GitHub
Star
utils/task.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function createTask has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.createTask = function (list_id, title, due_date, starred, reminder) {
  'use strict';
  due_date = due_date || '';
  starred = starred || false;
  var task_dict = {
Severity: Minor
Found in utils/task.js - About 1 hr to fix

    Function createTask has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    exports.createTask = function (list_id, title, due_date, starred, reminder) {
    Severity: Minor
    Found in utils/task.js - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.getTaskList = function(list_id, cb){
  api({url: '/tasks', qs: {list_id:list_id}},function(err, res, body){
    if(err) {
      log.error('Error getting task list!');
      log.error(err);
      Severity: Major
      Found in utils/task.js and 1 other location - About 2 hrs to fix
      utils/note.js on lines 14..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status