Showing 10 of 12 total issues

Method access_control has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

      def access_control(*args, &block)
        opts = args.extract_options!

        case args.size
        when 0 then true
Severity: Minor
Found in lib/acl9/controller_extensions.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Base has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Base
      include Prepositions

      attr_reader :allows, :denys

Severity: Minor
Found in lib/acl9/controller_extensions/dsl_base.rb - About 2 hrs to fix

    Method access_control has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def access_control(*args, &block)
            opts = args.extract_options!
    
            case args.size
            when 0 then true
    Severity: Major
    Found in lib/acl9/controller_extensions.rb - About 2 hrs to fix

      Method delete_role has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

            def delete_role(role)
              if role
                if ret = _role_objects.delete(role)
                  if role.send(_auth_subject_class_name.demodulize.tableize).empty?
                    ret &&= role.destroy unless role.respond_to?(:system?) && role.system?
      Severity: Minor
      Found in lib/acl9/model_extensions/for_subject.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _parse_and_add_rule has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def _parse_and_add_rule(*args)
              options = args.extract_options!
              options.keys.each { |key| _permitted_allow_deny_option!(key) }
      
              _set_action_clause( _retrieve_only(options), options.delete(:except))
      Severity: Minor
      Found in lib/acl9/controller_extensions/dsl_base.rb - About 1 hr to fix

        Method _parse_and_add_rule has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def _parse_and_add_rule(*args)
                options = args.extract_options!
                options.keys.each { |key| _permitted_allow_deny_option!(key) }
        
                _set_action_clause( _retrieve_only(options), options.delete(:except))
        Severity: Minor
        Found in lib/acl9/controller_extensions/dsl_base.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _set_action_clause has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def _set_action_clause(only, except)
                raise ArgumentError, "both :only (:to) and :except cannot be specified in the rule" if only && except
        
                @action_clause  = nil
                action_list     = only || except
        Severity: Minor
        Found in lib/acl9/controller_extensions/dsl_base.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method show_to has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def show_to(*args, &block)
              user = send(Acl9.config[:default_subject_method])
              return if user.nil?
        
              has_any = false
        Severity: Minor
        Found in lib/acl9/helpers.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method allowance_expression has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def allowance_expression
                allowed_expr    = @allows.any?  ? @allows.map { |clause| "(#{clause})" }.join(' || ') : 'false'
                not_denied_expr = @denys.any?   ? @denys.map { |clause| "!(#{clause})" }.join(' && ') : 'true'
        
                [allowed_expr, not_denied_expr].
        Severity: Minor
        Found in lib/acl9/controller_extensions/dsl_base.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method role_selecting_lambda has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def role_selecting_lambda(object)
                case object
                when Class
                  lambda { |role| role.authorizable_type == object.to_s }
                when default
        Severity: Minor
        Found in lib/acl9/model_extensions/for_subject.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language