bem-site/gorshochek

View on GitHub
src/tasks/docs/load-from-http.js

Summary

Maintainability
C
1 day
Test Coverage

Function exports has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(model, options) {
    options = options || {};
    options.concurrency = options.concurrency || 20;

    options.timeout = options.timeout || 10000;
Severity: Major
Found in src/tasks/docs/load-from-http.js - About 2 hrs to fix

    Function processPage has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function processPage(model, page) {
            debug(`load source viw http(s) for page with url: => ${page.url}`);
    
            const filePath = page.source; // относительный путь к файлу
            const fileName = path.basename(filePath); // имя файла (с расширением)
    Severity: Minor
    Found in src/tasks/docs/load-from-http.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              return Q.allSettled([
                  baseUtil.readFileFromCache(cacheFilePath),
                  loadDataFromUrl(page.source)
              ]).spread((cache, remote) => {
                  if(remote.state === 'rejected') {
      Severity: Major
      Found in src/tasks/docs/load-from-http.js and 1 other location - About 2 hrs to fix
      src/tasks/docs/load-from-file.js on lines 65..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              const onAddedDocument = (promise) => {
                  debug('Doc added: %s %s', page.url, page.title);
                  model.pushChangeToAddedGroup({type: 'doc', url: page.url, title: page.title});
                  return baseUtil.writeFileToCache(cacheFilePath, promise.value);
              };
      Severity: Major
      Found in src/tasks/docs/load-from-http.js and 3 other locations - About 2 hrs to fix
      src/tasks/docs/load-from-file.js on lines 54..58
      src/tasks/docs/load-from-file.js on lines 59..63
      src/tasks/docs/load-from-http.js on lines 95..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              const onModifiedDocument = (promise) => {
                  debug('Doc modified: %s %s', page.url, page.title);
                  model.pushChangeToModifiedGroup({type: 'doc', url: page.url, title: page.title});
                  return baseUtil.writeFileToCache(cacheFilePath, promise.value);
              };
      Severity: Major
      Found in src/tasks/docs/load-from-http.js and 3 other locations - About 2 hrs to fix
      src/tasks/docs/load-from-file.js on lines 54..58
      src/tasks/docs/load-from-file.js on lines 59..63
      src/tasks/docs/load-from-http.js on lines 90..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          function hasLocalSource(page) {
              const source = page.source;
              return !!source && !!source.match(/^https?/);
          }
      Severity: Minor
      Found in src/tasks/docs/load-from-http.js and 1 other location - About 35 mins to fix
      src/tasks/docs/load-from-file.js on lines 34..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status