Sign upLogin

benmarch/angular-ui-tour

View on GitHub
Star
app/tour-controller.js

Summary

Maintainability
F
3 days
Test Coverage

Function uiTourController has 300 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function uiTourController($timeout, $q, $filter, $document, TourConfig, uiTourBackdrop, uiTourService, TourStepService, hotkeys) {
    'ngInject';

    var self = new EventEmitter(),
        stepList = [],
Severity: Major
Found in app/tour-controller.js - About 1 day to fix

    Function uiTourController has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function uiTourController($timeout, $q, $filter, $document, TourConfig, uiTourBackdrop, uiTourService, TourStepService, hotkeys) {
    'ngInject';

    var self = new EventEmitter(),
        stepList = [],
    Severity: Minor
    Found in app/tour-controller.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File tour-controller.js has 305 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import angular from 'angular';
import EventEmitter from 'events';

export default function uiTourController($timeout, $q, $filter, $document, TourConfig, uiTourBackdrop, uiTourService, TourStepService, hotkeys) {
    'ngInject';
    Severity: Minor
    Found in app/tour-controller.js - About 3 hrs to fix

      Function goTo has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          self.goTo = async function (goTo) {
        var currentStep = getCurrentStep(),
            stepToShow = getStep(goTo),
            actionMap = {
                $prev: {
      Severity: Minor
      Found in app/tour-controller.js - About 1 hr to fix

        Function uiTourController has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export default function uiTourController($timeout, $q, $filter, $document, TourConfig, uiTourBackdrop, uiTourService, TourStepService, hotkeys) {
        Severity: Major
        Found in app/tour-controller.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                  return null;
          Severity: Major
          Found in app/tour-controller.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status