Sign upLogin

bestdramana/viking-ruby-converter

View on GitHub
Star

Showing 3 of 3 total issues

Method initialize has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize()
      @tags = []
      [
        ["h1", "#", ""],
        ["h2", "##", ""],
Severity: Major
Found in lib/viking/patterns/html.rb - About 2 hrs to fix

    Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize()
      @tags = []
      [
        ["h1", "#", ""],
        ["h2", "##", ""],
    Severity: Minor
    Found in lib/viking/patterns/html.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method replace_lists has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def replace_lists(htmlContent) 
      ulolReg = /<(ul|ol)\b[^>]*>([\s\S]*?)<\/\1>/
      convertedEls = ""
      
      # will contain the elements to replace once we've dealed with the scan
    Severity: Minor
    Found in lib/viking/patterns/html.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language