Sign upLogin

betagouv/service-national-universel

View on GitHub
Star
api/src/controllers/structure.js

Summary

Maintainability
A
1 hr
Test Coverage

Consider simplifying this complex logical expression.
Open

    if (req.query.withMissions || req.query.withReferents || req.query.withTeam) {
      let promises = [];

      if (req.query.withMissions) promises.push(populateWithMissions([structure]));
      else promises.push(async () => [structure]);
Severity: Major
Found in api/src/controllers/structure.js - About 40 mins to fix

    Function updateNetworkName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    async function updateNetworkName(structure, fromUser) {
  if (structure.networkId) {
    // When the structure is a child (part of a network), get the network
    const network = await StructureModel.findById(structure.networkId);
    // then update networkName thanks to its name.
    Severity: Minor
    Found in api/src/controllers/structure.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status