Sign upLogin

betagouv/service-national-universel

View on GitHub
Star
api/src/services/cle/referent.ts
6bb44edb

Summary

Maintainability
A
1 hr
Test Coverage

Function doInviteMultipleChefsEtablissements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export const doInviteMultipleChefsEtablissements = async (user: UserDto) => {
  const chefsEtablissementsToSendInvitation = await ReferentModel.find({
    "metadata.isFirstInvitationPending": true,
    role: ROLES.ADMINISTRATEUR_CLE,
    subRole: SUB_ROLES.referent_etablissement,
Severity: Minor
Found in api/src/services/cle/referent.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findOrCreateReferent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export const findOrCreateReferent = async (referent, { etablissement, role, subRole }: { etablissement: EtablissementType; role: string; subRole?: string }) => {
  try {
    // Return if already exists
    if (referent._id) return referent;
Severity: Minor
Found in api/src/services/cle/referent.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doInviteMultipleReferentClasseVerifiee has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export const doInviteMultipleReferentClasseVerifiee = async (user: UserDto) => {
  const referentsClasseToSendInvitation = await findReferentsClasseToSendInvitationByClasseStatus(STATUS_CLASSE.VERIFIED);
  const invitations: InvitationResult[] = [];
  let processCounter = 1;
  for (const referentClasse of referentsClasseToSendInvitation) {
Severity: Minor
Found in api/src/services/cle/referent.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status